-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement strict parsing checks #787
Comments
Whatever the design choices above, I want our error messages to be as helpful as possible. The two cases I have in mind so far are:
We will probably find more cases as we test this. |
Great tips for anyone using the OWLAPI here - I didn't know about unparsed triples! Your suggestion makes 100% self We already have |
@beckyjackson Does #788 completely address this, or is there still work to do? |
l believe this is resolved |
Based on #785 and owlcs/owlapi#988, I'd like to implement some sort of
--strict
option for ROBOT. This issue is for design feedback. Here's my first draft:Regarding the unparsed triples, we can ignore them (as we currently do), warn the user, or fail. For backwards compatibility, we can't just start always failing on unparsed triples, we would need some sort of
--strict
flag. I think we should change from ignoring to warning, but we'd have to try it out and see how common and annoying these warnings are.So I'm currently thinking that
ioHelper
should run a check after it loads an ontology: look at theOWLOntologyLoaderMetaData
to see if there are anyunparsedTriples
, and if there are any print a loud warning to STDERR with as helpful an message as we can write.OWLAPI also has a strict mode that we don't currently use. I'm thinking of adding a global
--strict true
option that would modifyioHelper
in two ways:OWLOntologyLoaderMetaData
We may want to add more strictness checks in the future. So maybe
--strict true
is all checks, but--strict
can take a list of checks, such asunparsed
.The text was updated successfully, but these errors were encountered: