Suppress logging for selected InvalidReferenceViolations #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this makes sense. I would love to stop seeing violations reported for subclass of |
|
Thanks @balhoff, no worries. I should have caught the problem. I'm leaning toward just merging this quick fix, releasing a 1.4.3, and sorting the rest out later. Thoughts? @beckyjackson @cmungall |
|
That sounds good to me. Thanks! |
balhoff
reviewed
Sep 12, 2019
robot-core/src/main/java/org/obolibrary/robot/ReasonOperation.java
Outdated
Show resolved
Hide resolved
This was referenced Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft of a fix for #567, also addresses #374, but it's a bit of a hack.
This suppresses error logging for InvalidReferenceViolations that I don't care about. The count of invalid references is the total, including suppressed, which will cause confusion. It would be cleaner to stop classifying these as violations at the source, or have a way to classify violations with more granularity.
The problem is that we care about different "violations" in different contexts. Repair now wants to see annotations on deprecated subjects as violations, but even deprecated subjects need a deprecation annotation and a label -- arguably any annotation should be fine.
I'm also suppressing errors for subClassOf ObsoleteClass and a few others, to satisfy #374. Arguably these are real violations, but with the ontologies I care about I don't want to see these.
I'm not sure what the best solution is.