-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an --intermediates option to extract #436
Conversation
If you have a class that is asserted to be a subclass of itself, the EDIT: sorry, meant to say Ideally an ontology shouldn't have circular subclasses, but in case it does happen, do we want this operation to fail with an error? Or should we just log a |
If redundant axioms are removed with reduce then there will be no cycles in the subclass graph |
True. I can just make it throw a message that says something like:
|
I don't think this is an error. It might be unusual, but I think the algorithm should just handle it. Maybe warn about it or provide an option to turn it into an error, but it is a valid situation. |
Closed in favor of #441 |
Intermediates
When extracting (especially with MIREOT), sometimes the hierarchy can have too many intermediate classes, making it difficult to identify relevant relationships. For example, you may end up with this after extracting
adrenal gland
:By specifying how to handle these intermediates, you can reduce unnecessary intermediate classes:
--intermediates all
: default behavior, do not prune the ontology--intermediates minimal
: only include intermediate intermediates with more than one sibling (i.e. the parent class has another child)--intermediates none
: do not include any intermediatesThe above example, with
--intermediates minimal
, would become:You can chain this output into
reduce
to further clean up the structure, as some redundant axioms may appear.With
--intermediates none
:Any term specified as an input term will not be pruned.