-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OWL API to 4.5.26 #1135
Update OWL API to 4.5.26 #1135
Conversation
</owl:AnnotationProperty> | ||
|
||
|
||
|
||
<!-- http://www.geneontology.org/formats/oboInOwl#id --> | ||
|
||
<owl:AnnotationProperty rdf:about="http://www.geneontology.org/formats/oboInOwl#id"/> | ||
<owl:AnnotationProperty rdf:about="http://www.geneontology.org/formats/oboInOwl#id"> | ||
<rdfs:label>id</rdfs:label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The necessity to add this was the only thing that was really important. @balhoff I wonder if you have an hypothesis why suddenly the id was necessary here to be added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or in other words, why suddenly the OWLAPI decided that in the presence of the
<owl:AnnotationProperty rdf:about="http://www.geneontology.org/formats/oboInOwl#id"/>
Now the <rdfs:label>id</rdfs:label>
was serialised out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it to this enum in my OWLAPI PR: https://github.com/owlcs/owlapi/pull/1099/files#diff-624125d6c0fdd02198cff3e52ece7ed9a49652cc11b4b68bf8a7970a9e35930dR58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thank you for the clarification.
The following ontologies changed their DL profile status: clo owl2_dl True False |
@balhoff suggests could be explained by owlcs/owlapi#1094 |
(For the eternal records, the violations are all true positive violations, e.g.)
|
Resolves #1129
docs/
have been added/updated (not necessary)mvn verify
says all tests passmvn site
says all JavaDocs correctCHANGELOG.md
has been updatedThe last OWL API version (4.5.25) had some major issues with the way complex turtle axioms are written, see #1129. This version solves this problem.