-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to annotate extracted entities with source #392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good.
Re: the ability to map via CSV. Potentially useful but I'd like some time to think this through. Don't want to unnecessarily complicate either ROBOT or the overall complexity of OBO ontology organization. I think if an ontology does adopt a URI then they should take responsibility for the isDefinedBys and they shouldn't be injected by an extract method. But overall we lack OBO docs on PURL adoption.
@cmungall - I forgot to add in a check for if the I know there has been some talk surrounding term "adoption" recently, especially with the OBO Core work. As this is something that impacts the OBO Foundry on a wider scale, this definitely requires more thought & input, but I wanted to have some sort of mock-up to demonstrate how it would work within ROBOT. Eventually, ROBOT could potentially have a default term-to-source map, like the prefix map, which would work behind the scenes. Again, these are just some first thoughts. |
@cmungall I'd like to get this PR merged. The core functionality to add |
agreed, merge away, conflict looks simple to fix |
Alright, this should be good to go! |
See #390
--annotate-with-source true
will addrdfs:isDefinedBy
to the term. Does not include annotations on the axiom, but that can be added as well. I'm not sure if this should be a different option though?--sources <arg>
allows you to define a term-to-source map file (as CSV or TSV) to redirect adopted entities, e.g.:If the term to extract isn't in that mapping file, the source is created from the term's IRI.
You can also do full IRIs for the sources (or terms) in the map.