Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to extract command to stamp classes with rdfs:isDefinedBy #390

Closed
cmungall opened this issue Oct 26, 2018 · 4 comments
Closed

Comments

@cmungall
Copy link
Contributor

If selected, each class in a generated module would have an isDefinedBy annotation to the URI of the source ontology, unless isDefinedBy is already present.

@balhoff
Copy link
Contributor

balhoff commented Oct 29, 2018

It seems to me that for extract it would make more sense to have the subject be the extracted axiom rather than the class.

In some of my code I do have a utility that adds isDefinedBy annotations terms that have OBO-style IRIs to the canonical ontology IRI for that OBO namespace (much faster to query for them this way than filtering on IRI text).

@cmungall
Copy link
Contributor Author

cmungall commented Oct 29, 2018 via email

@beckyjackson
Copy link
Contributor

We now have this feature with #392. Is this OK to close or does it require more discussion?

@cmungall
Copy link
Contributor Author

cmungall commented Feb 7, 2019

Yes we can add new tickets for enhanced functionality later

@cmungall cmungall closed this as completed Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants