Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change c style cast to c++ style cast #2936

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

mikeessen
Copy link
Collaborator

This PR updates c style casts to c++ style.

Signed-off-by: Mike Essenmacher <essen@us.ibm.com>
Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Mike

@mikeessen mikeessen merged commit 8dc51ac into onnx:main Sep 10, 2024
7 checks passed
@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14595 [push] Change c style cast to c... started at 13:45

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15569 [push] Change c style cast to c... started at 13:35

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15566 [push] Change c style cast to c... started at 12:36

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15566 [push] Change c style cast to c... passed after 1 hr 8 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15569 [push] Change c style cast to c... passed after 2 hr 0 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14595 [push] Change c style cast to c... aborted after 2 hr 3 min

Sunny-Anand pushed a commit to Sunny-Anand/onnx-mlir that referenced this pull request Sep 17, 2024
Signed-off-by: Mike Essenmacher <essen@us.ibm.com>
Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com>
Sunny-Anand added a commit that referenced this pull request Sep 17, 2024
* Change lowering of onnx.IF to Krnl (#2932)

* implementation

Signed-off-by: chentong319 <chentong@us.ibm.com>

* test case change

Signed-off-by: chentong319 <chentong@us.ibm.com>

* format

Signed-off-by: chentong319 <chentong@us.ibm.com>

* add test for If back

Signed-off-by: chentong319 <chentong@us.ibm.com>

* format

Signed-off-by: chentong319 <chentong@us.ibm.com>

---------

Signed-off-by: chentong319 <chentong@us.ibm.com>
Co-authored-by: Tung D. Le <tung@jp.ibm.com>
Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com>

* Update c style cast to c++ style cast (#2934)

Signed-off-by: Mike Essenmacher <essen@us.ibm.com>
Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com>

* Change c style cast to c++ style cast (#2936)

Signed-off-by: Mike Essenmacher <essen@us.ibm.com>
Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com>

* Add coding practices for onnx-mlir (#2935)

Signed-off-by: Mike Essenmacher <essen@us.ibm.com>
Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com>

* try to use new buffer deallocation (#2919)

* implementation

Signed-off-by: Chen Tong <chentong@us.ibm.com>

* comments

Signed-off-by: Chen Tong <chentong@us.ibm.com>

* format

Signed-off-by: Chen Tong <chentong@us.ibm.com>

---------

Signed-off-by: Chen Tong <chentong@us.ibm.com>
Co-authored-by: Tung D. Le <tung@jp.ibm.com>
Co-authored-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com>

* fix requirements.txt link

Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com>

* Reuse input buffer in lowering to krnl (#2939)

* first step

Signed-off-by: chentong319 <chentong@us.ibm.com>

* cpu

Signed-off-by: chentong319 <chentong@us.ibm.com>

* options

Signed-off-by: chentong319 <chentong@us.ibm.com>

* unify

Signed-off-by: chentong319 <chentong@us.ibm.com>

* simd

Signed-off-by: chentong319 <chentong@us.ibm.com>

* comments

Signed-off-by: chentong319 <chentong@us.ibm.com>

* lit test

Signed-off-by: chentong319 <chentong@us.ibm.com>

* fix test

Signed-off-by: chentong319 <chentong@us.ibm.com>

* format

Signed-off-by: chentong319 <chentong@us.ibm.com>

* response

Signed-off-by: chentong319 <chentong@us.ibm.com>

---------

Signed-off-by: chentong319 <chentong@us.ibm.com>
Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com>

* Fix GroupNorm to support Opset21 (#2928)

* Group norm for opset 21

* Testing phase

* Fix GroupNorm to support Opset21

---------

Signed-off-by: hamptonm1 <79232909+hamptonm1@users.noreply.github.com>
Co-authored-by: Megan Hampton <hamptonm@us.ibm.com>
Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com>

* Update Ops documentation for ONNX 1.16.2 (#2942)

* Update Ops documentation for ONNX 1.16.2

* Fix format

---------

Co-authored-by: Megan Hampton <hamptonm@us.ibm.com>
Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com>

* LLVM/StableHLO Upgrade eaa95a1 (#2943)

Co-authored-by: Megan Hampton <hamptonm@us.ibm.com>
Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com>

* added support for no-zero-point quantization (#2938)

Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Co-authored-by: Tung D. Le <tung@jp.ibm.com>
Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com>

* update with main

Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com>

---------

Signed-off-by: chentong319 <chentong@us.ibm.com>
Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com>
Signed-off-by: Mike Essenmacher <essen@us.ibm.com>
Signed-off-by: Chen Tong <chentong@us.ibm.com>
Signed-off-by: hamptonm1 <79232909+hamptonm1@users.noreply.github.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Sunny Anand <164108690+Sunny-Anand@users.noreply.github.com>
Co-authored-by: Tong Chen <chentong@us.ibm.com>
Co-authored-by: Tung D. Le <tung@jp.ibm.com>
Co-authored-by: Mike Essenmacher <112431871+mikeessen@users.noreply.github.com>
Co-authored-by: Alexandre Eichenberger <alexe@us.ibm.com>
Co-authored-by: hamptonm1 <79232909+hamptonm1@users.noreply.github.com>
Co-authored-by: Megan Hampton <hamptonm@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants