Add coding practices for onnx-mlir #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Essenmacher <essen@us.ibm.com>
AlexandreEichenberger
approved these changes
Sep 10, 2024
Signed-off-by: Mike Essenmacher <essen@us.ibm.com>
|
Jenkins Linux amd64 Build #15573 [push] Add coding practices for... started at 14:36 |
|
Jenkins Linux s390x Build #15577 [push] Add coding practices for... started at 15:37 |
|
Jenkins Linux ppc64le Build #14604 [push] Add coding practices for... started at 15:48 |
|
Jenkins Linux amd64 Build #15573 [push] Add coding practices for... passed after 1 hr 11 min |
|
Jenkins Linux s390x Build #15577 [push] Add coding practices for... passed after 1 hr 37 min |
|
Jenkins Linux ppc64le Build #14604 [push] Add coding practices for... passed after 2 hr 6 min |
Sunny-Anand
pushed a commit
to Sunny-Anand/onnx-mlir
that referenced
this pull request
Sep 17, 2024
Signed-off-by: Mike Essenmacher <essen@us.ibm.com> Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com>
Sunny-Anand
added a commit
that referenced
this pull request
Sep 17, 2024
* Change lowering of onnx.IF to Krnl (#2932) * implementation Signed-off-by: chentong319 <chentong@us.ibm.com> * test case change Signed-off-by: chentong319 <chentong@us.ibm.com> * format Signed-off-by: chentong319 <chentong@us.ibm.com> * add test for If back Signed-off-by: chentong319 <chentong@us.ibm.com> * format Signed-off-by: chentong319 <chentong@us.ibm.com> --------- Signed-off-by: chentong319 <chentong@us.ibm.com> Co-authored-by: Tung D. Le <tung@jp.ibm.com> Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com> * Update c style cast to c++ style cast (#2934) Signed-off-by: Mike Essenmacher <essen@us.ibm.com> Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com> * Change c style cast to c++ style cast (#2936) Signed-off-by: Mike Essenmacher <essen@us.ibm.com> Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com> * Add coding practices for onnx-mlir (#2935) Signed-off-by: Mike Essenmacher <essen@us.ibm.com> Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com> * try to use new buffer deallocation (#2919) * implementation Signed-off-by: Chen Tong <chentong@us.ibm.com> * comments Signed-off-by: Chen Tong <chentong@us.ibm.com> * format Signed-off-by: Chen Tong <chentong@us.ibm.com> --------- Signed-off-by: Chen Tong <chentong@us.ibm.com> Co-authored-by: Tung D. Le <tung@jp.ibm.com> Co-authored-by: Alexandre Eichenberger <alexe@us.ibm.com> Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com> * fix requirements.txt link Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com> * Reuse input buffer in lowering to krnl (#2939) * first step Signed-off-by: chentong319 <chentong@us.ibm.com> * cpu Signed-off-by: chentong319 <chentong@us.ibm.com> * options Signed-off-by: chentong319 <chentong@us.ibm.com> * unify Signed-off-by: chentong319 <chentong@us.ibm.com> * simd Signed-off-by: chentong319 <chentong@us.ibm.com> * comments Signed-off-by: chentong319 <chentong@us.ibm.com> * lit test Signed-off-by: chentong319 <chentong@us.ibm.com> * fix test Signed-off-by: chentong319 <chentong@us.ibm.com> * format Signed-off-by: chentong319 <chentong@us.ibm.com> * response Signed-off-by: chentong319 <chentong@us.ibm.com> --------- Signed-off-by: chentong319 <chentong@us.ibm.com> Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com> * Fix GroupNorm to support Opset21 (#2928) * Group norm for opset 21 * Testing phase * Fix GroupNorm to support Opset21 --------- Signed-off-by: hamptonm1 <79232909+hamptonm1@users.noreply.github.com> Co-authored-by: Megan Hampton <hamptonm@us.ibm.com> Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com> * Update Ops documentation for ONNX 1.16.2 (#2942) * Update Ops documentation for ONNX 1.16.2 * Fix format --------- Co-authored-by: Megan Hampton <hamptonm@us.ibm.com> Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com> * LLVM/StableHLO Upgrade eaa95a1 (#2943) Co-authored-by: Megan Hampton <hamptonm@us.ibm.com> Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com> * added support for no-zero-point quantization (#2938) Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> Co-authored-by: Tung D. Le <tung@jp.ibm.com> Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com> * update with main Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com> --------- Signed-off-by: chentong319 <chentong@us.ibm.com> Signed-off-by: Sunny-Anand <sunnyanand.979@gmail.com> Signed-off-by: Mike Essenmacher <essen@us.ibm.com> Signed-off-by: Chen Tong <chentong@us.ibm.com> Signed-off-by: hamptonm1 <79232909+hamptonm1@users.noreply.github.com> Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> Signed-off-by: Sunny Anand <164108690+Sunny-Anand@users.noreply.github.com> Co-authored-by: Tong Chen <chentong@us.ibm.com> Co-authored-by: Tung D. Le <tung@jp.ibm.com> Co-authored-by: Mike Essenmacher <112431871+mikeessen@users.noreply.github.com> Co-authored-by: Alexandre Eichenberger <alexe@us.ibm.com> Co-authored-by: hamptonm1 <79232909+hamptonm1@users.noreply.github.com> Co-authored-by: Megan Hampton <hamptonm@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a coding practices documentation file to describe the coding practices to use when updating or adding code to onnx-mlir.