Add events #19
Add events #19
Conversation
Kay-Zee
requested review from
janezpodhostnik,
psiemens and
turbolent
as code owners
flow/result.go
Outdated
| for _, blockEvent := range events { | ||
| fmt.Printf("Events for Block %s:", blockEvent.BlockID) | ||
| for i, blockEvent := range events { | ||
| fmt.Printf("Events for Block %s (%d):", blockEvent.BlockID, startHeight+uint64(i)) |
There was a problem hiding this comment.
What does the number in parenthesis represent?
There was a problem hiding this comment.
it's the height of the block. better to label?
|
Example usage: |
|
Could you add a events help indication that shows the correct format of an event definition in case people don't know to use |
flow/events/get/get.go
Outdated
| var conf Config | ||
|
|
||
| var Cmd = &cobra.Command{ | ||
| Use: "get <event_name> <block_height_range_start> <optional:block_height_range_end|latest>", |
There was a problem hiding this comment.
Maybe use "type ID" instead of "name", as someone might assume it's possible to just specify e.g AccountCreated.
Also, maybe make it clearer that latest here is a literal, not a variable like block_height_range_start and block_height_range_end
| Use: "get <event_name> <block_height_range_start> <optional:block_height_range_end|latest>", | |
| Use: "get <event_type_id> <block_height_range_start> <optional:block_height_range_end|'latest'>", |
|
@Kay-Zee Maybe add your example as |
Closes #18
Description
Adds new
eventssub command thatFor contributor use:
masterbranchFiles changedin the Github PR explorer