Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request events for block range #18

Closed
Kay-Zee opened this issue Dec 29, 2020 · 0 comments · Fixed by #19
Closed

Request events for block range #18

Kay-Zee opened this issue Dec 29, 2020 · 0 comments · Fixed by #19
Assignees
Labels
Feature A new user feature or a new package API

Comments

@Kay-Zee
Copy link
Member

Kay-Zee commented Dec 29, 2020

Issue To Be Solved

Currently, it's only possible to get block events for a single block at a time. The access API currently supports getting event info for multiple blocks at once. We should try and leverage this functionality.

Suggest A Solution

We should either:
a) Add the ability to query multiple blocks at once using the current API. (i.e. put under the blocks sub command)

  • The advantage here is a large amount of reusable code
  • The disadvantage is that we'd actually not use the events API provided by the access API in a very optimized way

b) Add a new subcommand events which would simply query events.

  • The advantage would be a cleaner separation of intent, and better use of the AccessAPI,
  • The disadvantage would be that we'd now be able to query events from both the blocks and events sub commands, which could be somewhat confusing, as well as still not having the ability to query multiple blocks at once

I am likely to do a PoC of option b) and go from there.

@Kay-Zee Kay-Zee added the Feature A new user feature or a new package API label Dec 29, 2020
@Kay-Zee Kay-Zee self-assigned this Dec 29, 2020
@Kay-Zee Kay-Zee mentioned this issue Dec 29, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new user feature or a new package API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants