Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new revertibleRandom function #423

Merged
merged 8 commits into from
Nov 7, 2023
Merged

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented Oct 26, 2023

  • doc for new revertibleRandom function
  • add deprecation info for unsafeRandom
  • update description of randomness behaviour

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 5:22pm

Copy link
Member

@AlexHentschel AlexHentschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this PR to document the new revertibleRandom. Unfortunately, I think we duplicated work, as I already created this draft PR #156 Sorry, I should have reminded you again that this already existed.

I tried to merge the content of my PR into yours (see suggestions) and closed my older PR. Hope that reduces overhead on your end.

docs/cadence/language/built-in-functions.mdx Outdated Show resolved Hide resolved
docs/cadence/language/built-in-functions.mdx Outdated Show resolved Hide resolved
docs/cadence/language/built-in-functions.mdx Outdated Show resolved Hide resolved
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but are in the wrong place: The changes are editing the documentation for the next version of Cadence, i.e. Cadence 1.0 ("Stable Cadence"). The documentation for the current version is under versioned_docs/version-stable/cadence.

Changes needed:

  1. Apply these changes to versioned_docs/version-stable/cadence/language/built-in-functions.mdx instead
  2. Change the currently edited page (docs/cadence/language/built-in-functions.mdx) so that it reflects the state after Cadence 1.0 has been deployed, i.e. remove the unsafeRandom section

Copy link
Contributor

@gregsantos gregsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2G

@tarakby
Copy link
Contributor Author

tarakby commented Nov 7, 2023

Thanks for the feedback @turbolent, that's very helpful! Please let me know if I'm updating the right pages now, and I'll merge this PR

@turbolent turbolent merged commit 40b6bbc into main Nov 7, 2023
2 checks passed
@turbolent turbolent deleted the tarak/2869-revertible-random branch November 7, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants