-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new revertibleRandom
function
#423
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this PR to document the new revertibleRandom
. Unfortunately, I think we duplicated work, as I already created this draft PR #156 Sorry, I should have reminded you again that this already existed.
I tried to merge the content of my PR into yours (see suggestions) and closed my older PR. Hope that reduces overhead on your end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, but are in the wrong place: The changes are editing the documentation for the next version of Cadence, i.e. Cadence 1.0 ("Stable Cadence"). The documentation for the current version is under versioned_docs/version-stable/cadence
.
Changes needed:
- Apply these changes to
versioned_docs/version-stable/cadence/language/built-in-functions.mdx
instead - Change the currently edited page (
docs/cadence/language/built-in-functions.mdx
) so that it reflects the state after Cadence 1.0 has been deployed, i.e. remove theunsafeRandom
section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg2G
Thanks for the feedback @turbolent, that's very helpful! Please let me know if I'm updating the right pages now, and I'll merge this PR |
revertibleRandom
functionunsafeRandom