Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for changing unsafeRandom -> secureRandom #156

Closed
wants to merge 2 commits into from
Closed

Update documentation for changing unsafeRandom -> secureRandom #156

wants to merge 2 commits into from

Conversation

AlexHentschel
Copy link
Member

this PR suggests new documentation for upgrading unsafeRandom to secureRandom

@vercel
Copy link

vercel bot commented Jun 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ❌ Failed (Inspect) Jun 30, 2023 10:45pm

@turbolent turbolent requested review from dsainati1 and SupunS June 30, 2023 22:59
@tarakby
Copy link
Contributor

tarakby commented Jul 4, 2023

Thank you for the PR @AlexHentschel !
After discussing with the Cadence team last week, we decided that the new name as well as how/when unsafeRandom will be deprecated will be proposed in a FLIP (that I'll submit). Therefore, I suggest to keep this PR open till the FLIP outcome is decided. Only then we can adjust the documentation PR accordingly and merge.

@AlexHentschel
Copy link
Member Author

superseded by PR #423

@AlexHentschel AlexHentschel mentioned this pull request Nov 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent Awaiting requested review from turbolent

@tarakby tarakby Awaiting requested review from tarakby

@dsainati1 dsainati1 Awaiting requested review from dsainati1

@SupunS SupunS Awaiting requested review from SupunS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexHentschel @tarakby