[EXP][OpenCL] Update kernel commands in a command-buffer #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
force-pushed
the
ewan/mutable_dispatch_update
branch
from
67da5d8
to
8def359
Compare
EwanC
changed the title
EwanC
force-pushed
the
ewan/mutable_dispatch_update
branch
from
8def359
to
9f5fe08
Compare
martygrant
approved these changes
Feb 20, 2024
test/conformance/exp_command_buffer/buffer_fill_kernel_update.cpp
Outdated
Show resolved
Hide resolved
EwanC
force-pushed
the
ewan/mutable_dispatch_update
branch
from
9f5fe08
to
ede570c
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1358 +/- ##
==========================================
- Coverage 14.82% 12.43% -2.39%
==========================================
Files 250 241 -9
Lines 36220 36230 +10
Branches 4094 4112 +18
==========================================
- Hits 5369 4506 -863
- Misses 30800 31720 +920
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
EwanC
force-pushed
the
ewan/mutable_dispatch_update
branch
2 times, most recently
from
3ceb6d9
to
5eeb6cf
Compare
EwanC
force-pushed
the
ewan/mutable_dispatch_update
branch
from
5eeb6cf
to
a442cbf
Compare
EwanC
force-pushed
the
ewan/mutable_dispatch_update
branch
from
a442cbf
to
df68355
Compare
EwanC
force-pushed
the
ewan/mutable_dispatch_update
branch
2 times, most recently
from
7419c39
to
3ba6673
Compare
kbenzie
added
conformance
kbenzie
added
the
command-buffer
Implement the API for updating the kernel commands in a command-buffer defined by oneapi-src#1089 for the OpenCL adapter. However, the following changes to the UR kernel update API have been made based on implementation experience: 1. Forbid updating the work-dim of the kernel, see KhronosGroup/OpenCL-Docs#1057 2. Remove struct fields to update exec info, after [DPC++ implementation prototype](intel/llvm#12840) shows this isn't needed. 3. Forbid changing the local work size from user to impl defined and vice-versa. See discussion in [L0 implementation PR](oneapi-src#1353 (comment)). This adapter implementation depends on support for the [cl_khr_command_buffer_mutable_dispatch](https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_Ext.html#cl_khr_command_buffer_mutable_dispatch) extension. Tested on Intel GPU/CPUs OpenCL implementations with the [command-buffer emulation layer](https://github.com/bashbaug/SimpleOpenCLSamples/tree/main/layers/10_cmdbufemu). ```bash $ OPENCL_LAYERS=<path/to/SimpleOpenCLSamples/build/layers/10_cmdbufemu/libCmdBufEmu.so> ./bin/test-exp_command_buffer --platform="Intel(R) OpenCL Graphics" ``` DPC++ PR intel/llvm#12724
EwanC
force-pushed
the
ewan/mutable_dispatch_update
branch
from
3ba6673
to
1449fa1
Compare
EwanC
force-pushed
the
ewan/mutable_dispatch_update
branch
from
1449fa1
to
c3c5406
Compare
sommerlukas
pushed a commit
to intel/llvm
that referenced
this pull request
Apr 24, 2024
Test the UR commit that enables updating kernel commands in a command-buffer in the OpenCL adapter oneapi-src/unified-runtime#1358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the API for updating the kernel commands in a command-buffer defined by #1089 for the OpenCL adapter.
However, the following changes to the UR kernel update API have been made based on implementation experience:
This adapter implementation depends on support for the cl_khr_command_buffer_mutable_dispatch extension.
Tested on Intel GPU/CPUs OpenCL implementations with the command-buffer emulation layer.
DPC++ PR intel/llvm#12724