[EXP][Command-buffer] OpenCL kernel command update #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
requested review from
ori-sky,
reble,
Bensuo,
julianmi and
mfrancepillois
EwanC
force-pushed
the
ewan/mutable_dispatch_update
branch
from
2cd1cc3
to
6abac95
Compare
| CL_RETURN_ON_FAILURE( | ||
| deviceSupportsURCommandBufferKernelUpdate(CLDevice, SupportsUpdate)); | ||
|
|
||
| const bool Updatable = IsUpdatable && SupportsUpdate; |
There was a problem hiding this comment.
Should we return a warning or something if IsUpdatable==true and SupportUpdate==false?
There was a problem hiding this comment.
Yes! We should return an error, which should also be defined by the spec. Added that now.
Implement the API for updating the kernel commands in a command-buffer defined by oneapi-src#1089 for the OpenCL adapter. This depends on support for the [cl_khr_command_buffer_mutable_dispatch](https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_Ext.html#cl_khr_command_buffer_mutable_dispatch) extension. Tested on Intel GPU OpenCL implementations with the [command-buffer emulation layer](https://github.com/bashbaug/SimpleOpenCLSamples/tree/main/layers/10_cmdbufemu). ```bash $ OPENCL_LAYERS=<path/to/SimpleOpenCLSamples/build/layers/10_cmdbufemu/libCmdBufEmu.so> ./bin/test-exp_command_buffer --platform="Intel(R) OpenCL Graphics" ```
EwanC
force-pushed
the
ewan/mutable_dispatch_update
branch
2 times, most recently
from
34978e0
to
a30dc3b
Compare
EwanC
force-pushed
the
ewan/mutable_dispatch_update
branch
from
a30dc3b
to
67da5d8
Compare
Bensuo
approved these changes
Feb 19, 2024
|
Moved to an upstream PR oneapi-src#1358 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the API for updating the kernel commands in a command-buffer defined by oneapi-src#1089 for the OpenCL adapter.
This depends on support for the cl_khr_command_buffer_mutable_dispatch extension.
Tested on Intel GPU OpenCL implementations with the command-buffer emulation layer.
DPC++ PR intel/llvm#12724