Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill color #13

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Fill color #13

merged 5 commits into from
Feb 15, 2024

Conversation

Rdornier
Copy link
Contributor

@Rdornier Rdornier commented Feb 12, 2024

I added here the possibility to fill ROIs with a color, with a different opacity.
Everything seesm to work well, except one thing within the small GUI.

  1. Select one color for the stroke color
  2. Select a different one for the fill color
  3. When you click to draw the shape, the radio button changes automatically to match the exact same color in the GUI, but the two different colors have been taken into account for the drawing.

It does not affect the core functionnality but it is annyoing to have a GUI different from what it is drawn. I don't know what exactly happen and couldn't find any fix for now.

Edit: It is related to this issue ome/omero-figure#485

src/js/shapeManager.js Outdated Show resolved Hide resolved
src/js/docs.js Outdated Show resolved Hide resolved
@will-moore
Copy link
Member

Working well, with the fixes above.
I wonder if you could also add this to the index.html <style> block, since it's easier to see what's going on with a black background to the canvas:

			#shapesCanvas {
				background-color: black;
			}

@Rdornier
Copy link
Contributor Author

Thanks for your review.
I fixed the bugs and added the black background.

Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@will-moore will-moore merged commit cd8a542 into ome:master Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants