Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROI shape fill colour #485

Open
will-moore opened this issue Oct 13, 2022 · 4 comments
Open

ROI shape fill colour #485

will-moore opened this issue Oct 13, 2022 · 4 comments

Comments

@will-moore
Copy link
Member

See https://forum.image.sc/t/couple-of-suggestions-about-omero-figure/72675

"When editing ROIs, there is not option to fill the ROI with color and transparency. Similarly, if we want to load ROIs that are filled with transparency in iviewer, only ROIs boundaries are imported into omero.figure. Is it possible to have the fill ROI option in omero.figure, either for creating and loading ROIs ?"

@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/couple-of-suggestions-about-omero-figure/72675/2

@Rdornier
Copy link
Contributor

Hello @will-moore

I have a question regarding the shapeManager. How can I do to add attribute/methods to it ? I would like to add a setFillColor method to be able to fill it but I couldn't find anything.

Thanks,
All the best,
Rémy.

@will-moore
Copy link
Member Author

The shape-editor is currently a separate repo https://github.com/ome/shape-editor and installed from
https://www.npmjs.com/package/@openmicroscopy/shape-editor
at

"@openmicroscopy/shape-editor": "^4.0.0"

However, the original reason for that decision was to allow it's reuse elsewhere, but we have never done that so I think we could simply copy it into omero-figure.

This is what I've done in my long-running update of figure at #477

I need to spend some time reviving that PR and fixing merge conflicts with all the updates since I started that!

@Rdornier
Copy link
Contributor

Hi,

The shape-editor is currently a separate repo https://github.com/ome/shape-editor and installed from

That's why ! Thanks for the info

I need to spend some time reviving that PR and fixing merge conflicts with all the updates since I started that!

Do you mean that it is better to wait for that PR before we continue working on that issue ?

Rémy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants