Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break utils.py #387

Merged
merged 3 commits into from
May 15, 2020
Merged

break utils.py #387

merged 3 commits into from
May 15, 2020

Conversation

jburel
Copy link
Member

@jburel jburel commented May 14, 2020

Re-organise code, having import omero prevents the deployment via travis

 File "setup.py", line 31, in <module>
    import [secure]ro_figure.utils as utils
  File "/h[secure]/travis/build/[secure]/[secure]ro-figure/[secure]ro_figure/utils.py", line 21, in <module>
    from [secure]ro.sys import ParametersI
ModuleNotFoundError: No module named '[secure]ro'

To test this PR:

  • create a conda env with nodejs only (not omero)
  • run python setup.py sdist

Problem introduced in #378
cc @will-moore

@will-moore
Copy link
Member

Looks good. 👍

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading about the context, I had been wondering whether setup.py was missing a dependency but then I realized that the sdist target is independent of install_requires.

In that sense, having the module in charge of the version sourcing independent of the omero-py dependency makes complete sense. For future discussions, other options allowing to achieve the single-sourcing of the package version are described here.

NBL I also fixed the

    from [secure]ro.sys import ParametersI

by making the PYPI_USER variable visible in the Travis logs.

@jburel jburel merged commit 4bb7376 into ome:master May 15, 2020
@jburel jburel deleted the fix branch August 20, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants