-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timestamp format millisecs #378
Conversation
Integer division and rounding were broken since Python 3. Also added support for 'millisecs' and 'mins:secs' formats
The slider shows |
@jburel Which label? What format did you choose for the label? |
[mins:secs] |
Then the label should say |
it is rounded to the nearest second |
If the user chooses |
We could add a format for |
Thanks |
Fixes #375
This adds supports for displaying timestamp labels in milliseconds or mins:secs.
Previously, all timestamps were loaded as seconds (timestamps were rounded when images were added to figures) and these integer values are stored in the figure JSON, so all existing figures can't have timestamps in milliseconds.
So, when older figures are open (VERSION 4) we now load un-rounded timestamps from the server to update those values in the figure JSON.
This allows us to choose "milliseconds" for timestamp labels (also "mins:secs") AND fixes the display of milliseconds for the label beside the T-slider.
To test:
00:03:45.02
.