-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page colour #211
Page colour #211
Conversation
Conflicting PR. Removed from build FIGURE-merge#426. See the console output for more details.
|
All the rest works as expected, except #211 (comment). Discussed the bug with @bramalingam - if this is intended behaviour, then maybe rather remove the feature completely (feature = being clever about black on black and white on white). |
To test last commit:
|
Works as expected. Ready to merge. |
src/js/models/panel_model.js
Outdated
labels[j].color == "FFFFFF") { | ||
labels[j].color = "000000"; | ||
} | ||
// // check that we're not adding a white label outside panel (on a white background) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove if it is no longer needed
@@ -130,7 +130,8 @@ def __init__(self, canvas, panel, page, crop, page_height): | |||
elif shape['type'] == "Ellipse": | |||
self.draw_ellipse(shape) | |||
|
|||
def get_rgb(self, color): | |||
@staticmethod | |||
def get_rgb(color): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moving to @staticmethod means that this could be used everywhere and no need to have the same method line 424
Addressed comments from @jburel.
|
Works as expected. Ready to merge. |
Allows you to change the background colour of the pages.
See https://trello.com/c/55EzQq2e/14-set-page-colour
To test:
NB: I'll need to upload script before the export is tested