-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown labels #209
Markdown labels #209
Conversation
Very nice feature, the help menu is a good idea given the various markdown formats. The display in figure works for bold, italics and link though the link hidden under the svg (z-index) so that it cannot be clicked in figure itself but that may be intentional. The no-wrap of longer labels is consistent in figure and exported versions. I read your remark about python markdown on eel but couldn't see the html tag effects in the pdf/tiff I exported but then again it might be better to wait till eel has the respective markdown library installed anyhow. |
@waxenegger Sorry, I forgot that I need to upload the script manually. I just uploaded it now (seems to be working) but can do it again whenever you're ready to test. |
The export works now using html tags. |
Bug with non-square panels causing incorrect positioning of left-vertical label (from @bramalingam) |
@bramalingam @will-moore did you import such images on eel to make the testing easier? |
The markdown suggestions work as expected. Looks good to merge. |
@jburel You can use this figure for testing http://web-dev-merge.openmicroscopy.org/figure/file/19809/ (user-1) |
Adds support for markdown in panel labels as requested in https://trello.com/c/BNjiEiAZ/3-labels-italics
To test:
NB: Python markdown is not currently installed on eel server, so you will need to enter html labels to see these formatted correctly on export. See http://web-dev-merge.openmicroscopy.org/figure/file/17802/ (user-3).