Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uselessness of the adaptable params, MinSelfDelegationLimited #47

Closed
4 tasks
RevelationOfTuring opened this issue Apr 18, 2020 · 0 comments · Fixed by #57
Closed
4 tasks

Uselessness of the adaptable params, MinSelfDelegationLimited #47

RevelationOfTuring opened this issue Apr 18, 2020 · 0 comments · Fixed by #57
Assignees
@RevelationOfTuring
Labels
types Issues or features relating to the types (sdk) package. x/staking Changes, features and bugs related to the staking module.

Comments

@RevelationOfTuring
Copy link
Contributor

RevelationOfTuring commented Apr 18, 2020 •
edited
Loading

Summary

As the default value of msd, it seems useless for the adaptable params MinSelfDelegationLimited in staking params.

Problem Definition

Uselessness of the params, MinSelfDelegationLimited , which could be changed by validator's proposal, makes a waste of params check in func handleMsgCreateValidator(...)... .

Proposal

It's better to keep pace with issue #46 by removing the adaptable params MinSelfDelegationLimited.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@RevelationOfTuring RevelationOfTuring added types Issues or features relating to the types (sdk) package. x/staking Changes, features and bugs related to the staking module. labels Apr 18, 2020
RevelationOfTuring added a commit that referenced this issue Apr 20, 2020
@RevelationOfTuring
FIX: issue #47 && recover staking ut
65bd809
@RevelationOfTuring RevelationOfTuring mentioned this issue Apr 20, 2020
Merged
5 tasks
zhongqiuwood added a commit that referenced this issue Apr 22, 2020
@RevelationOfTuring @zhongqiuwood
FIX: issue #47 && recover staking ut (#57)
f87c0a3 
Co-authored-by: Zhong Qiu <36867992+zhongqiuwood@users.noreply.github.com>
@RevelationOfTuring RevelationOfTuring mentioned this issue Apr 29, 2020
Closed
cwbhhjl pushed a commit that referenced this issue Mar 17, 2023
@ylsGit @KamiD
Close ibc by default (#47)
1598bf8 
Co-authored-by: KamiD <44460798+KamiD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RevelationOfTuring RevelationOfTuring

Labels
types Issues or features relating to the types (sdk) package. x/staking Changes, features and bugs related to the staking module.
Projects
None yet
Milestone
No milestone
1 participant
@RevelationOfTuring