Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing the field MinSelfDelegation from MsgCreateValidator #46

Closed
4 tasks
RevelationOfTuring opened this issue Apr 18, 2020 · 0 comments
Closed
4 tasks

removing the field MinSelfDelegation from MsgCreateValidator #46

RevelationOfTuring opened this issue Apr 18, 2020 · 0 comments
Assignees
@zhongqiuwood
Labels
enhancement New feature or request x/staking Changes, features and bugs related to the staking module.

Comments

@RevelationOfTuring
Copy link
Contributor

Summary

As the default value of msd during the validator creation, it's acceptable to remove the field MinSelfDelegation from MsgCreateValidator technically.

Problem Definition

Field MinSelfDelegation in MsgCreateValidator is useless now.

Proposal

It's a good idea to make the bytes length of any msg as short as possible for the fees paid.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@RevelationOfTuring RevelationOfTuring added x/staking Changes, features and bugs related to the staking module. enhancement New feature or request labels Apr 18, 2020
@RevelationOfTuring RevelationOfTuring mentioned this issue Apr 18, 2020
Closed
4 tasks
@zhongqiuwood zhongqiuwood changed the title Consider to remove the field MinSelfDelegation from MsgCreateValidator removing the field MinSelfDelegation from MsgCreateValidator Apr 22, 2020
RevelationOfTuring added a commit that referenced this issue Apr 22, 2020
@RevelationOfTuring
FIX: issue #46. Removing the field MinSelfDelegation from MsgCreateVa…
85b823b 
…lidator
@RevelationOfTuring RevelationOfTuring mentioned this issue Apr 22, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhongqiuwood zhongqiuwood

Labels
enhancement New feature or request x/staking Changes, features and bugs related to the staking module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX: Removing the field MinSelfDelegation from MsgCreateValidator okx/exchain
3 participants
@xiangjianmeng @zhongqiuwood @RevelationOfTuring