This repository has been archived by the owner on Jan 26, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 232
[WIP DON'T MERGE] Setting custom error agents #146
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import Auth from '../../src/Auth'; | ||
|
|
||
| const pkg = require('../../package.json'); | ||
|
|
||
| test('Auth component sets the right user agent on AuthJS', () => { | ||
| const auth = new Auth({ | ||
| issuer: 'https://foo/oauth2/default' | ||
| }); | ||
| const expectedUserAgent = `${pkg.name}/${pkg.version} okta-auth-js-`; | ||
| expect(auth._oktaAuth.userAgent).toMatch(expectedUserAgent); | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import AuthJS from '@okta/okta-auth-js' | ||
| import { createLocalVue } from '@vue/test-utils' | ||
| import { default as Auth } from './Auth' | ||
|
|
||
| jest.mock('@okta/okta-auth-js') | ||
|
|
||
| const mockAuthJsInstance = {userAgent: 'foo'} | ||
|
|
||
| AuthJS.mockImplementation(() => { | ||
| return mockAuthJsInstance | ||
| }) | ||
|
|
||
| const pkg = require('../package.json') | ||
|
|
||
| describe('Auth', () => { | ||
| test('is a Vue plugin', () => { | ||
| expect(Auth.install).toBeTruthy() | ||
| }) | ||
| test('sets the right user agent on AuthJS', () => { | ||
| const expectedUserAgent = `${pkg.name}/${pkg.version} foo` | ||
| createLocalVue().use(Auth, { | ||
| issuer: '1', | ||
| client_id: '2', | ||
| redirect_uri: '3' | ||
| }) | ||
| expect(mockAuthJsInstance.userAgent).toMatch(expectedUserAgent) | ||
| }) | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| const fs = require('fs'); | ||
| const path = require('path'); | ||
|
|
||
| const workingDirectory = process.argv[2]; | ||
| const destinationFile = process.argv[3]; | ||
| const packageJsonPath = path.join(process.cwd(), workingDirectory, 'package.json') | ||
| const configDest = path.join(process.cwd(), workingDirectory, destinationFile); | ||
| const packageJson = require(packageJsonPath); | ||
| const packageInfo = { | ||
| name: packageJson.name, | ||
| version: packageJson.version | ||
| }; | ||
| const output = 'export default ' + JSON.stringify(packageInfo, null, 2) + ';' | ||
|
|
||
| console.log('Writing config to', configDest); | ||
|
|
||
| fs.writeFileSync(configDest, output); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this pickup the
okta-auth-jsversion too?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To assert that, you need to know which version is currently depended on. Ideas I had that I didn't love: