This repository has been archived by the owner on Jan 26, 2025. It is now read-only.
[WIP DON'T MERGE] Setting custom error agents #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmelberg-okta
approved these changes
Mar 13, 2018
| const auth = new Auth({ | ||
| issuer: 'https://foo/oauth2/default' | ||
| }); | ||
| const expectedUserAgent = `${pkg.name}/${pkg.version} okta-auth-js-`; |
There was a problem hiding this comment.
Shouldn't this pickup the okta-auth-js version too?
There was a problem hiding this comment.
To assert that, you need to know which version is currently depended on. Ideas I had that I didn't love:
- Lock package.json down to a specific patch version
- Fish into node modules to see what's currently installed.
- Use a regex in the matcher, to at least assert the whole thing looks like what we expect
robertjd
force-pushed
the
rd-wip-user-agents
branch
from
51e62e9 to
b4312aa
Compare
robertjd
force-pushed
the
rd-wip-user-agents
branch
from
b4312aa to
7679c8e
Compare
|
Closing WIP PR in favor of #151 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on okta/okta-auth-js#98
Shows how I'm thinking of handing this in React, Angular. Will look at vue next