Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.pre-commit-config.yaml: Add codespell #43

Merged
merged 4 commits into from
May 4, 2020
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Apr 27, 2020

Fixes #42

  1. Commit 1 Add codespell to pre-commit.yaml -- CI tests are not run :-(
    • It unsafe to assume that outside contributors have pre-commit properly installed.
  2. Commit 2 Add a GitHub Action to run this repo's pre-commit on all incoming PRs -- ❌
    • Trust but verify
  3. Commit 3 Fix typo discovered by codespell -- ✅

@okken
Copy link
Owner

okken commented May 4, 2020

Very cool. Thank you for this addition.
Also appreciate the demo of adding pre-commit to a github action

@okken okken merged commit f86857e into okken:master May 4, 2020
@cclauss cclauss deleted the patch-1 branch May 4, 2020 14:47
@peternewman
Copy link

For info, there's also an action already in the marketplace to do all the pre-commit stuff automatically for you:
https://github.com/marketplace/actions/pre-commit

And probably with a bit more error checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add codespell to the testing?
3 participants