-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a GitHub Action for codespell #1499
Add a GitHub Action for codespell #1499
Comments
For just how awesome this is, see here: |
Seems useful to me |
First draft: We'll need to move this into the project at some point too. I'm sure it needs a bit of tidying up... |
It's also currently catching the line buffering error from #1331 . |
Hi, |
Heh thanks @plettich . Have you got a ReviewDog one you could link to? Or alternatively here's the first draft of annotations, which I assume is probably better: I can't take any credit though, I've just taken @TrueBrain 's hard work and changed a few trivial bits! |
The code can be found here: https://github.com/plettich/action-codespell |
Thanks @plettich . Looks like ReviewDog only adds a little bit of noise, but I suspect doing it directly would be easiest. |
We should also get this repo moved to the codespell-project org at some point @larsoner . I think I just temporarily need the right to create repositories in the org to be able to migrate it. |
That's neat @cclauss . Personally I think the annotation is the real winner here, although I think we could also ship an action which just adds the matchers (and use that in our full action), so you'd then get the best of both worlds. |
actually it also limits the output only to the code touched in the PR, which can be nice if You have a large Project and don't want to struggle with excluding files and samples. |
@plettich now our action is released and in use by people, do you fancy signposting it from your action? It might also avoid you needing to deal with issues like this 😉 : |
Could this issue be closed? |
Using this seems easiest:
https://github.com/actions/toolkit/blob/master/docs/problem-matchers.md
This looks like quite a good example to base it on:
https://github.com/TrueBrain/actions-flake8
There are a couple of Codespell actions already:
https://github.com/marketplace?type=actions&query=codespell
Both by @plettich .
One just uses the dictionary, and so presumably would need an update for out multi-dictionary, won't have the same options etc (as well as only creating review comments):
https://github.com/marketplace/actions/codespell-action
The other one uses Review Dog, which seems like an unnecessary overhead now the problem matchers exist:
https://github.com/marketplace/actions/run-codespell-with-reviewdog
The text was updated successfully, but these errors were encountered: