Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo fixes #837

Merged
merged 2 commits into from
Aug 7, 2021
Merged

Typo fixes #837

merged 2 commits into from
Aug 7, 2021

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Jul 30, 2021

Found via codespell -q 3 -S *.js -L ba

@luzpaz
Typo fixes
9e481b4 
Found via `codespell -q 3 -S *.js -L ba`
@codecov
Copy link

codecov bot commented Jul 30, 2021 •
edited
Loading

Codecov Report

Merging #837 (077b353) into master (7afbb37) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 077b353 differs from pull request most recent head a7f62f2. Consider uploading reports for the commit a7f62f2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #837   +/-   ##
=======================================
  Coverage   95.15%   95.15%           
=======================================
  Files          32       32           
  Lines        7495     7495           
  Branches      799      799           
=======================================
  Hits         7132     7132           
  Misses        224      224           
  Partials      139      139
Impacted Files Coverage Δ
cadquery/assembly.py 93.13% <0.00%> (ø)
cadquery/cq.py 91.42% <ø> (ø)
cadquery/occ_impl/geom.py 88.67% <ø> (ø)
cadquery/occ_impl/importers.py 88.42% <ø> (ø)
cadquery/occ_impl/shapes.py 92.47% <ø> (ø)
cadquery/selectors.py 98.14% <ø> (ø)
tests/test_cadquery.py 99.20% <ø> (ø)
tests/test_cqgi.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7afbb37...a7f62f2. Read the comment docs.

jmwright
jmwright approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luzpaz this is great. I just had the one comment.

I wonder if the check you did should be added to CI to prevent these types of spelling errors from creeping back in.

cadquery/cq.py Outdated
@@ -698,7 +698,7 @@ def first(self: T) -> T:
def item(self: T, i: int) -> T:
"""

Return the ith item on the stack.
Return the nth item on the stack.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ith was correct here since the index variable was i.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, reverted in a7f62f2

@luzpaz
Copy link
Contributor Author

luzpaz commented Jul 31, 2021

I wonder if the check you did should be added to CI to prevent these types of spelling errors from creeping back in.

Yes, some repos have done this. I don't have that info in front of me right now.

@jmwright
Copy link
Member

jmwright commented Aug 6, 2021

@marcus7070 @adam-urbanczyk Do either of you want to check these spelling fixes before I merge?

@luzpaz
Copy link
Contributor Author

luzpaz commented Aug 6, 2021

I wonder if the check you did should be added to CI to prevent these types of spelling errors from creeping back in.

Yes, some repos have done this. I don't have that info in front of me right now.

Check out codespell-project/codespell#1499

@adam-urbanczyk
Copy link
Member

I skimmed and it LGTM.

@adam-urbanczyk adam-urbanczyk self-requested a review August 7, 2021 22:59
@jmwright
Copy link
Member

jmwright commented Aug 7, 2021

@luzpaz Thanks!

@jmwright jmwright merged commit 4c45eb2 into CadQuery:master Aug 7, 2021
@luzpaz luzpaz deleted the typos branch August 8, 2021 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-urbanczyk adam-urbanczyk adam-urbanczyk approved these changes

@jmwright jmwright jmwright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luzpaz @jmwright @adam-urbanczyk