Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update errors report design #645

Merged
merged 8 commits into from
Nov 22, 2024
Merged

Update errors report design #645

merged 8 commits into from
Nov 22, 2024

Conversation

guergana
Copy link
Collaborator

@guergana guergana commented Nov 14, 2024

@guergana guergana requested a review from romicolman November 14, 2024 19:28
@guergana
Copy link
Collaborator Author

@romicolman @Faithkenny Maybe we should thing about some sort of indicator when the user has to scroll to the right? Sometimes the errors report has many columns and i think it's not immediately obvious that there is more information if you scroll to the right. I have made a gif to illustrate what I see:

Peek 2024-11-15 19-34

Copy link

cloudflare-workers-and-pages bot commented Nov 16, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9a0cb2b
Status: ✅  Deploy successful!
Preview URL: https://0773321e.opendataeditor.pages.dev
Branch Preview URL: https://634-errors-report.opendataeditor.pages.dev

View logs

@Faithkenny
Copy link
Collaborator

@romicolman @Faithkenny Maybe we should thing about some sort of indicator when the user has to scroll to the right? Sometimes the errors report has many columns and i think it's not immediately obvious that there is more information if you scroll to the right. I have made a gif to illustrate what I see:

Peek 2024-11-15 19-34 Peek 2024-11-15 19-34

Very good catch @guergana. Let's review this on Monday. A max-width container is the first solution that jumps at me

@romicolman
Copy link
Collaborator

Hi @guergana thanks for this implementation. To answer to your comments:

  1. The scrolling problem: we are having a call today with Faith to address other elements and we added this to our discussion list.

  2. During the user testing sessions, people did not detect the first column in the error tables as the row number. Faith has added a gray background on this first column to follow the Google Sheets and Excel logic and visually facilitates it detection. I checked this on the Figma file and it is there. Can you please add it?

  3. In addition, can you please add the Row number title. In the current design, the row number is called 1:

Captura de pantalla 2024-11-18 a la(s) 2 15 21 p  m
  1. I also detected a problem when the content in the cell with the error is too large: we have a lot of blank space on the left menu and the width of the rows is disproportionate. Is there a way to solve this? Maybe by adding a tooltip for long content. This is a video showing the problem:
Grabacion.de.pantalla.2024-11-18.a.la.s.2.40.00.p.m.mov
  1. In files with a lot of errors, when scrolling down the errors report to click show more, nothing happens. Here is a video showing the problem:
Grabacion.de.pantalla.2024-11-18.a.la.s.2.48.18.p.m.mov
  1. As we discussed on Slack we removed the detailed explanation of errors, to avoid repeating information. We will have more user testing sessions to check if this works if this change makes sense or if we need to include the element again.

@Faithkenny
Copy link
Collaborator

On the call yesterday, I pointed out that we should have the Settings section (user guide & report an issue) in a fixed position. Giving more thought to this made me realize that I haven't shared a definition for the scrolling, and overscroll behaviour in the ODE. Here goes:

  • The sidebar, control panel containing metadata and co. including the Pagination should be fixed always
  • The Datagrid area which changes based on the viewed panel scrolls behind the control panel

This Prototype demonstrates what it should look like.

Happy to hear your thoughts @guergana @romicolman @pdelboca

Scrolling.behaviour.mp4

@guergana
Copy link
Collaborator Author

guergana commented Nov 21, 2024

Hi @guergana thanks for this implementation. To answer to your comments:

1. The scrolling problem: we are having a call today with Faith to address other elements and we added this to our discussion list.

2. During the user testing sessions, people did not detect the first column in the error tables as the row number. Faith has added a gray background on this first column to follow the Google Sheets and Excel logic and visually facilitates it detection. I checked this on the [Figma file](https://www.figma.com/design/cOpYjy35zB3dJf1GW1BC76/Open-Data-Editor?node-id=10002-64459&t=hHNUCVdrF7s2rGht-1) and it is there. Can you please add it?

3. In addition, can you please add the **Row number** title. In the current design, the row number is called **1**:
Captura de pantalla 2024-11-18 a la(s) 2 15 21 p  m
4. I also detected a problem when the content in the cell with the error is too large: we have a lot of blank space on the left menu and the width of the rows is disproportionate. Is there a way to solve this? Maybe by adding a tooltip for long content. This is a video showing the problem:

Grabacion.de.pantalla.2024-11-18.a.la.s.2.40.00.p.m.mov

5. In files with a lot of errors, when scrolling down the errors report to click show more, nothing happens. Here is a video showing the problem:

Grabacion.de.pantalla.2024-11-18.a.la.s.2.48.18.p.m.mov

6. As we discussed on Slack we removed the detailed explanation of errors, to avoid repeating information. We will have more user testing sessions to check if this works if this change makes sense or if we need to include the element again.

Hello @romicolman could you please provide the file you used for testing? 🙏
About point 2. ... if there is no indication of the row error, how are users going to know where is the error? Without the error detail and the line in the table there is no indication on this report about which lines have errors.

@romicolman
Copy link
Collaborator

Yes, here is Distribucio.de.la.renda.P80_P20 (1).xlsx.

@guergana
Copy link
Collaborator Author

Yes, here is Distribucio.de.la.renda.P80_P20 (1).xlsx.

@romicolman I have worked on the changes. . I couldn't yet find a solution to the tooltip in the table report when the cells are too big, I just set a fixed height for now and cut the rest out.

@guergana guergana requested review from roll and pdelboca November 22, 2024 05:05
@romicolman
Copy link
Collaborator

Hi @guergana! Just to post what we discussed yesterday. Bullet point 2 is the indication of the row number. Faith added a gray background to make that indication clearer to the user. Regarding the problem with the tooltip, I'll create a separate ticket. Let's merge this for now

Copy link
Collaborator

@romicolman romicolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is approved! You can merge it :)

@guergana guergana merged commit 9f36713 into main Nov 22, 2024
9 checks passed
@guergana guergana deleted the 634-errors-report branch November 22, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Errors Report panel design
4 participants