-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update errors report design #645
Conversation
guergana
commented
Nov 14, 2024
•
edited
Loading
edited
- fixes New Errors Report panel design #634
@romicolman @Faithkenny Maybe we should thing about some sort of indicator when the user has to scroll to the right? Sometimes the errors report has many columns and i think it's not immediately obvious that there is more information if you scroll to the right. I have made a gif to illustrate what I see: |
Deploying opendataeditor with
|
Latest commit: |
9a0cb2b
|
Status: | ✅ Deploy successful! |
Preview URL: | https://0773321e.opendataeditor.pages.dev |
Branch Preview URL: | https://634-errors-report.opendataeditor.pages.dev |
Very good catch @guergana. Let's review this on Monday. A max-width container is the first solution that jumps at me |
Hi @guergana thanks for this implementation. To answer to your comments:
![]()
Grabacion.de.pantalla.2024-11-18.a.la.s.2.40.00.p.m.mov
Grabacion.de.pantalla.2024-11-18.a.la.s.2.48.18.p.m.mov
|
On the call yesterday, I pointed out that we should have the Settings section (user guide & report an issue) in a fixed position. Giving more thought to this made me realize that I haven't shared a definition for the scrolling, and overscroll behaviour in the ODE. Here goes:
This Prototype demonstrates what it should look like. Happy to hear your thoughts @guergana @romicolman @pdelboca Scrolling.behaviour.mp4 |
Hello @romicolman could you please provide the file you used for testing? 🙏 |
Yes, here is Distribucio.de.la.renda.P80_P20 (1).xlsx. |
@romicolman I have worked on the changes. . I couldn't yet find a solution to the tooltip in the table report when the cells are too big, I just set a fixed height for now and cut the rest out. |
Hi @guergana! Just to post what we discussed yesterday. Bullet point 2 is the indication of the row number. Faith added a gray background to make that indication clearer to the user. Regarding the problem with the tooltip, I'll create a separate ticket. Let's merge this for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is approved! You can merge it :)