Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

Library metadata is displayed in hover window + kludge bug fix #14

Merged
merged 5 commits into from
May 25, 2018

Conversation

slazicoicr
Copy link
Collaborator

I noticed a weird bug in the data.table package that does not pop up on Google.

If data.table::fread causes a warning and the warning is caught, the function is left in a failed state. The next valid call to fread will fail again, as the function has to reset itself. A valid call after the reset will work fine.

I am manually making a (kludgy) valid call to fread each time a warning is caught to reset it.

The issue is at Rdatatable/data.table#2904

# The next valid call to fread will fail again, as the function has to reset itself. The next valid call will work fine.
# I am manually making a valid call to fread to reset it
# Issue is at https://github.com/Rdatatable/data.table/issues/2904
tryCatch({

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 That's quite a bug.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 hours of my life right there. The good news is that my Issue was deemed a bug, so there was a purpose to my hair pulling.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the report. 10 years of my life hair pulling on data.table now.

@slazicoicr slazicoicr merged commit 5d09fd4 into master May 25, 2018
@slazicoicr slazicoicr deleted the dev_hover branch May 25, 2018 18:18
@morgantaschuk morgantaschuk removed their request for review January 17, 2019 18:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants