Remove duplicate age #9928

rajku-dev · 2025-01-13T08:41:42Z

Proposed Changes

Fixes Incorrect Patient Age displayed on Appointment page #9922
Removed rendering age two times

BEFORE

AFTER

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

UI/UX Improvements
- Simplified patient information display in Appointment Details
- Updated age and date of birth presentation to be more concise and readable

coderabbitai · 2025-01-13T08:41:50Z

Walkthrough

The pull request modifies the AppointmentDetail.tsx file to streamline the rendering of patient information, specifically the date of birth and age. The logic for displaying these details has been simplified using a ternary operator to check for the existence of date_of_birth and year_of_birth. This change enhances the clarity of the code while maintaining the same functionality.

Changes

File	Change Summary
`src/pages/Appointments/AppointmentDetail.tsx`	Simplified conditional rendering of patient date of birth and age calculation

Assessment against linked issues

Objective	Addressed	Explanation
Correct Patient Age Display [#9922]	✅

Possibly related PRs

Patients age is correctly defined #9680: This PR modifies the formatPatientAge function, which is directly related to the age calculation logic mentioned in the main PR's changes to the AppointmentDetail.tsx file.

Suggested labels

tested, reviewed, P1

Suggested reviewers

rithviknishad
Jacobjeevan

Poem

🐰 A Rabbit's Ode to Age Display 🎂

Bits of code, once verbose and wide,
Now trimmed with elegance and pride.
Patient's age, no longer cluttered,
A simple line, perfectly uttered.
Hop, hop, hooray for clean design! 🎉

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cad9cd0 and 1ed683e.

📒 Files selected for processing (1)

src/pages/Appointments/AppointmentDetail.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/pages/Appointments/AppointmentDetail.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-01-13T08:42:00Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`1ed683e`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67860473c42d060008bf975d
😎 Deploy Preview	https://deploy-preview-9928--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/pages/Appointments/AppointmentDetail.tsx (1)

294-295: LGTM! Consider these minor improvements

The changes successfully remove the duplicate age display while maintaining a clean and readable format. Two suggestions for enhancement:

Consider moving the years translation into the age display for better readability:

-                    {differenceInYears(
-                      new Date(),
-                      appointment.patient.date_of_birth!,
-                    )}
-                  </>
-                )}{" "}
-                {t("years")}
+                    {`${differenceInYears(
+                      new Date(),
+                      appointment.patient.date_of_birth!,
+                    )} ${t("years")}`}
+                  </>
+                )}

Add an aria-label for better accessibility:

-              <p className="text-gray-600">
+              <p className="text-gray-600" aria-label={`${t("date_of_birth_and_age")}`}>

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19239d5 and b3be81c.

📒 Files selected for processing (1)

src/pages/Appointments/AppointmentDetail.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: cypress-run (1)

src/pages/Appointments/AppointmentDetail.tsx

…ev/care_fe into issue/9922/incorrect-age

rithviknishad

code is not readable. use ternary operator instead

rajku-dev · 2025-01-13T19:04:53Z

code is not readable. use ternary operator instead

note taken, will take care of that,
Also i think

we are keeping both fields(year_of_birth and date_of_birth) optional in type
though we know at least one of the fields will definitely be present
in this case we should use discriminated union

rithviknishad · 2025-01-14T02:21:07Z

doesn't backend always give you the year_of_birth? (correct me if im wrong)

rajku-dev · 2025-01-14T03:29:29Z

doesn't backend always give you the year_of_birth? (correct me if im wrong)

I created a patient with just date_of_birth and found that backend always provides the year_of_birth.

src/pages/Appointments/AppointmentDetail.tsx

github-actions · 2025-01-14T07:36:31Z

@rajku-dev Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Remove duplicate age

a43cf8c

rajku-dev requested a review from a team as a code owner January 13, 2025 08:41

Merge branch 'develop' into issue/9922/incorrect-age

b3be81c

coderabbitai bot reviewed Jan 13, 2025

View reviewed changes

Jacobjeevan requested changes Jan 13, 2025

View reviewed changes

src/pages/Appointments/AppointmentDetail.tsx Show resolved Hide resolved

Jacobjeevan added the changes required label Jan 13, 2025

rajku-dev and others added 3 commits January 13, 2025 23:24

conditionally render date_of_birth or year_of_birth age

2a7af95

Merge branch 'issue/9922/incorrect-age' of https://github.com/rajku-d…

85058d9

…ev/care_fe into issue/9922/incorrect-age

Merge branch 'develop' into issue/9922/incorrect-age

38d1377

rithviknishad requested changes Jan 13, 2025

View reviewed changes

use ternary operator

cad9cd0

fix conditional rendering logic

e6dcd50

rithviknishad requested changes Jan 14, 2025

View reviewed changes

src/pages/Appointments/AppointmentDetail.tsx Outdated Show resolved Hide resolved

Merge branch 'develop' into issue/9922/incorrect-age

1ed683e

Jacobjeevan approved these changes Jan 14, 2025

View reviewed changes

Jacobjeevan added needs testing needs review and removed changes required labels Jan 14, 2025

rithviknishad approved these changes Jan 14, 2025

View reviewed changes

rithviknishad merged commit bc152cc into ohcnetwork:develop Jan 14, 2025
17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove duplicate age #9928

Remove duplicate age #9928

rajku-dev commented Jan 13, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 13, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Jan 13, 2025 •

edited

Loading

coderabbitai bot left a comment

rithviknishad left a comment

rajku-dev commented Jan 13, 2025 •

edited

Loading

rithviknishad commented Jan 14, 2025 •

edited

Loading

rajku-dev commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

Remove duplicate age #9928

Remove duplicate age #9928

Conversation

rajku-dev commented Jan 13, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Jan 13, 2025 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Jan 13, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

rithviknishad left a comment

Choose a reason for hiding this comment

rajku-dev commented Jan 13, 2025 • edited Loading

rithviknishad commented Jan 14, 2025 • edited Loading

rajku-dev commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

rajku-dev commented Jan 13, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 13, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Jan 13, 2025 •

edited

Loading

rajku-dev commented Jan 13, 2025 •

edited

Loading

rithviknishad commented Jan 14, 2025 •

edited

Loading