Patients age is correctly defined #9680

NikhilA8606 · 2025-01-03T04:57:29Z

Proposed Changes

Fixes Patient age format is not working properly #9640

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

Bug Fixes
- Improved patient age formatting by providing a direct return for known ages.
- Enhanced display of patient age information for better clarity and conciseness.

coderabbitai · 2025-01-03T04:57:36Z

Walkthrough

The pull request modifies the formatPatientAge function in src/Utils/utils.ts. A new conditional check is added to return the patient's age as a string in the format ${obj.age} Y if the age property is not null, streamlining the function's logic for known ages. The previous logic for calculating age based on birth dates remains intact, ensuring that if the age is not provided, the function will still compute it as before. The changes do not introduce new functions or modify exported entities.

Changes

File	Change Summary
`src/Utils/utils.ts`	Modified `formatPatientAge` function to return age directly as a string if known, while preserving existing logic for calculating age from birth dates. Removed unnecessary `suffixes` variable.

Possibly related PRs

Fixed the date format in the user details page #9409: Modifies date formatting logic in UserViewDetails.tsx using formatDate from Utils/utils, which is relevant to date handling improvements.

Suggested labels

tested, reviewed, P1

Suggested reviewers

rithviknishad
khavinshankar

Poem

🐰 In the land of code where ages play,
A rabbit found a simpler way.
With just a check, the years unfold,
A string of ages, bright and bold!
No more fuss, just swift delight,
In utils we trust, everything feels right! ✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 72c02fb and c3baa7b.

📒 Files selected for processing (1)

src/Utils/utils.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/Utils/utils.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-01-03T04:57:54Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`c3baa7b`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67777837b064e50007e66b93
😎 Deploy Preview	https://deploy-preview-9680--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad

nice find!

rithviknishad · 2025-01-03T05:01:16Z

src/Utils/utils.ts

-    return abbreviated
-      ? `Born ${obj.year_of_birth}`
-      : `Born on ${obj.year_of_birth}`;
+    return abbreviated ? `${obj.age} Y` : `Born on ${obj.year_of_birth}`;


but if year_of_birth is undefined, and abbreviated is set to false, this would still have the same issue right?

instead let's check if age is null or not and show age if available, else fallback to year of birth

Is it correct?

no, let's keep old year of birth if age is not present (same as before). if backend gives us age, let's show age directly before reaching there.

Suggested change

return abbreviated ? `${obj.age} Y` : `Born on ${obj.year_of_birth}`;

if (age != null) return `${obj.age} Y`;

return abbreviated ? `Born ${obj.year_of_birth}` : `Born on ${obj.year_of_birth}`;

Is it what you meant?

yup! this one's better!

github-actions · 2025-01-03T05:45:03Z

@NikhilA8606 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Patients age is correctly defined

72c02fb

NikhilA8606 requested a review from a team as a code owner January 3, 2025 04:57

rithviknishad approved these changes Jan 3, 2025

View reviewed changes

rithviknishad added the good to merge label Jan 3, 2025

rithviknishad requested changes Jan 3, 2025

View reviewed changes

rithviknishad added changes required and removed good to merge labels Jan 3, 2025

Patients age is fixed

c3baa7b

rithviknishad approved these changes Jan 3, 2025

View reviewed changes

rithviknishad added tested reviewed reviewed by a core member and removed changes required labels Jan 3, 2025

rithviknishad merged commit ae5e944 into ohcnetwork:develop Jan 3, 2025
19 checks passed

This was referenced Jan 9, 2025

robustify UserCreateForm #9852

Closed

Remove duplicate age #9928

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Patients age is correctly defined #9680

Patients age is correctly defined #9680

NikhilA8606 commented Jan 3, 2025 •

edited by rithviknishad

Loading

coderabbitai bot commented Jan 3, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Jan 3, 2025 •

edited

Loading

rithviknishad left a comment

rithviknishad Jan 3, 2025

NikhilA8606 Jan 3, 2025

rithviknishad Jan 3, 2025 •

edited

Loading

NikhilA8606 Jan 3, 2025

rithviknishad Jan 3, 2025 •

edited

Loading

github-actions bot commented Jan 3, 2025

	return abbreviated ? `${obj.age} Y` : `Born on ${obj.year_of_birth}`;
	if (age != null) return `${obj.age} Y`;
	return abbreviated ? `Born ${obj.year_of_birth}` : `Born on ${obj.year_of_birth}`;

Patients age is correctly defined #9680

Patients age is correctly defined #9680

Conversation

NikhilA8606 commented Jan 3, 2025 • edited by rithviknishad Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Jan 3, 2025 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Jan 3, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

rithviknishad left a comment

Choose a reason for hiding this comment

rithviknishad Jan 3, 2025

Choose a reason for hiding this comment

NikhilA8606 Jan 3, 2025

Choose a reason for hiding this comment

rithviknishad Jan 3, 2025 • edited Loading

Choose a reason for hiding this comment

NikhilA8606 Jan 3, 2025

Choose a reason for hiding this comment

rithviknishad Jan 3, 2025 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Jan 3, 2025

NikhilA8606 commented Jan 3, 2025 •

edited by rithviknishad

Loading

coderabbitai bot commented Jan 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Jan 3, 2025 •

edited

Loading

rithviknishad Jan 3, 2025 •

edited

Loading

rithviknishad Jan 3, 2025 •

edited

Loading