Work with setuptools_scm 8.0 (fix #50) #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make test_write even less brittle (see also ofek#8, ofek#9, ofek#25) so that it works with _version.py files generated by at least setuptools_scm 8.0, 7.1, 7.0, and 6.4. This is required because setuptools_scm 8.0 added a type-checking comment at the end of the version line. Based on: https://src.fedoraproject.org/fork/lbalhar/rpms/python-hatch-vcs/c/ca6e8a95dbe50da64ba98c4e0829ae00ccd8025a
musicinmybrain
force-pushed
the
setuptools_scm8
branch
from
ddff408
to
d2d0c13
Compare
RonnyPfannschmidt
approved these changes
Sep 22, 2023
|
@ofek can the ruff job get a own matrix element, the 3.9 failure looks scary else |
ofek
approved these changes
Sep 22, 2023
|
With this and #26, do you think it’s time to make a 0.3.1 release soon? On one hand, the fixes are only for the tests and don’t affect the correctness of the PyPI wheels. On the other hand, a new release would reduce the number of patches that various distributors need to carry in order to run the tests. |
|
If you have time would you mind fixing the lint errors? After that I can definitely make a release tonight or sometime tomorrow |
|
IMO it would be good to release new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make test_write even less brittle (see also #8, #9, #25) so that it works with _version.py files generated by at least setuptools_scm 8.0, 7.1, 7.0, and 6.4.
This is required because setuptools_scm 8.0 added a type-checking comment at the end of the version line.
This is a follow-up to #26.