-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with setuptools_scm 7 #8
Comments
The failure is caused by this change: pypa/setuptools-scm@b45e19f#diff-bdefa0298003efada7c465428643cc6d9c129168afb3eb5c551b40fcc77feac1 We can either check that the What do you prefer? |
@RonnyPfannschmidt is there any simple way to get the version of setuptools_scm? Something like |
@frenzymadness asking importlib metadata is the intended way at the moment, i think i should add a version attribute thats lazily computed |
@frenzymadness, thank you for diagnosing and fixing this. I will go ahead and apply your PR in the Fedora package for now to unblock your @ofek, do you prefer the approach in #9, or do you prefer to write something like assert lines[3].endswith("version = '1.2.3'") to accommodate both older and newer |
I prefer ^ quick fix b/c I plan to switch to https://hatch.pypa.io/dev/plugins/build-hook/version/ |
Make test_write even less brittle (see also ofek#8, ofek#9, ofek#25) so that it works with _version.py files generated by at least setuptools_scm 8.0, 7.1, 7.0, and 6.4. This is required because setuptools_scm 8.0 added a type-checking comment at the end of the version line. Based on: https://src.fedoraproject.org/fork/lbalhar/rpms/python-hatch-vcs/c/ca6e8a95dbe50da64ba98c4e0829ae00ccd8025a
Make test_write even less brittle (see also #8, #9, #25) so that it works with _version.py files generated by at least setuptools_scm 8.0, 7.1, 7.0, and 6.4. This is required because setuptools_scm 8.0 added a type-checking comment at the end of the version line. Based on: https://src.fedoraproject.org/fork/lbalhar/rpms/python-hatch-vcs/c/ca6e8a95dbe50da64ba98c4e0829ae00ccd8025a
I'm testing hatch-vcs with the latest setuptools_scm and one test fails:
The text was updated successfully, but these errors were encountered: