Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #587

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

Krishnakalani111
Copy link
Contributor

resolves : #578

@Krishnakalani111 Krishnakalani111 requested a review from a team as a code owner October 4, 2023 11:36
Copy link
Collaborator

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. The fix LGTM.

To merge, I want to verify that the node auto instrumentation works as expected after the change. Please let me know if you run it locally and seen if everything still works. If you need help with setting up an environment, please let me know here and I can assist.

@Krishnakalani111
Copy link
Contributor Author

It would be very helpful if I had the docs to setup the required things to check the effect of changes in package.json of node js file.
@blumamir

@blumamir
Copy link
Collaborator

It would be very helpful if I had the docs to setup the required things to check the effect of changes in package.json of node js file. @blumamir

First step is to setup a cluster and install odigos as described in the quickstart. Once you have a kind cluster that runs odigos, you can build the images from your source code with TAG=v0.1.79 make build-images and then push it to the kind cluster with TAG=v0.1.79 make load-to-kind. This pushes the new code, after which you can restart odiglet so it loads the updated build, and restart a nodejs service in the target application to have it instrumented with the new version.

Please let me know if you need further details. I can also verify it myself if you don't have time to setup everything 🙏

@blumamir blumamir merged commit ed1237f into odigos-io:main Oct 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove unused dependencies from nodejs instrumentation agent
2 participants