Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused dependencies from nodejs instrumentation agent #578

Closed
blumamir opened this issue Oct 4, 2023 · 2 comments · Fixed by #587
Closed

remove unused dependencies from nodejs instrumentation agent #578

blumamir opened this issue Oct 4, 2023 · 2 comments · Fixed by #587
Assignees
@Krishnakalani111
Labels
good first issue Good for newcomers hacktoberfest

Comments

@blumamir
Copy link
Collaborator

blumamir commented Oct 4, 2023

Odigos nodejs agent includes some unused dependencies in package.json.

Since the agent does not collect metrics at the moment, I think these are redundant:

  • "@opentelemetry/sdk-metrics"
  • "@opentelemetry/exporter-metrics-otlp-grpc"
  • "@opentelemetry/exporter-prometheus"

@edeNFed - WDYT?
@edeNFed
Copy link
Contributor

edeNFed commented Oct 4, 2023

👍🏻 sounds like a great idea

@Krishnakalani111
Copy link
Contributor

i want to contribute, please assign this to me

Krishnakalani111 added a commit to Krishnakalani111/odigos that referenced this issue Oct 4, 2023
@Krishnakalani111
Update package.json
5d8e136 
resolves : odigos-io#578
@Krishnakalani111 Krishnakalani111 mentioned this issue Oct 4, 2023
Merged
blumamir pushed a commit that referenced this issue Oct 15, 2023
@Krishnakalani111
Update package.json (#587)
ed1237f 
resolves : #578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Krishnakalani111 Krishnakalani111

Labels
good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update package.json Krishnakalani111/odigos
3 participants
@edeNFed @blumamir @Krishnakalani111