Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename action endpoints #1125

Merged
merged 14 commits into from
Apr 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ jobs:
with:
repository: 'open-telemetry/opentelemetry-helm-charts'
path: opentelemetry-helm-charts
# Remove once open-telemetry/opentelemetry-helm-charts#1143 is merged
ref: e0c6b9c95c4c4710c3d986e56b9e86ff32de6210
- name: Install Collector - Helm install
run: helm install test -f .github/workflows/e2e/collector-helm-values.yaml opentelemetry-helm-charts/charts/opentelemetry-collector --namespace traces --create-namespace
- name: Wait for Collector to be ready
Expand Down
2 changes: 1 addition & 1 deletion api/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ SHELL = /usr/bin/env bash -o pipefail
.SHELLFLAGS = -ec

.PHONY: all
all: build
all: generate manifests

##@ General

Expand Down
17 changes: 4 additions & 13 deletions docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,25 +8,16 @@ Simply merge in this PR and your documentation will be connected!

### 👩‍💻 Development

Install the [Mintlify CLI](https://www.npmjs.com/package/mintlify) to preview the documentation changes locally. To install, use the following command
The documentation is build on [Mintlify](https://www.npmjs.com/package/mintlify). To preview the documentation changes locally:

```
npm i mintlify -g
```

Run the following command at the root of your documentation (where mint.json is)

```
mintlify dev
# make sure you're in `/docs` folder, where `mint.json` and `package.json` files are
npm ci
npm run dev
```

### 😎 Publishing Changes

Changes will be deployed to production automatically after pushing to the default branch.

You can also preview changes using PRs, which generates a preview link of the docs.

#### Troubleshooting

- Mintlify dev isn't running - Run `mintlify install` it'll re-install dependencies.
- Mintlify dev is updating really slowly - Run `mintlify clear` to clear the cache.
8 changes: 4 additions & 4 deletions docs/adding-new-dest.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ corresponds to the type of input field that will be displayed in the UI.
field of the returned object and secret data (like API key) - defined in the
`Secret` field of the returned object.

```js
```ts
toObjects = (req: NextApiRequest) => {
return {
Data: {
Expand All @@ -112,7 +112,7 @@ toObjects = (req: NextApiRequest) => {
Kubernetes data store to the data that will be displayed in the UI. This
method is invoked when user edits the destination in the UI.

```js
```ts
mapDataToFields = (data: any) => {
return {
url: data.MYDEST_URL,
Expand Down Expand Up @@ -146,7 +146,7 @@ need to implement the collector configuration.
2. Go to `autoscaler/controllers/gateway/config` directory and create a new file
called `mydest.go` with the following content:

```js
```go
package config

import (
Expand Down Expand Up @@ -196,7 +196,7 @@ func (m *MyDest) ModifyConfig(dest *odigosv1.Destination, currentConfig *commonc
- The last step is to register the new destination struct in the
`autoscaler/controllers/gateway/config/root.go` file:

```js
```go
var availableConfigers = []Configer{/* List of existing destinations */, &MyDest{}}
```

Expand Down
3 changes: 2 additions & 1 deletion docs/mint.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@
"pipeline/actions/introduction",
"pipeline/actions/addclusterinfo",
"pipeline/actions/deleteattribute",
"pipeline/actions/rename-attribute",
"pipeline/actions/crd",
"pipeline/actions/troubleshooting"
]
Expand All @@ -111,7 +112,7 @@
},
{
"group": "Observability Backends",
"pages": [
"pages": [
"backends/awss3",
"backends/azureblob",
"backends/coralogix",
Expand Down
Loading
Loading