Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename action endpoints #1125

Merged
merged 14 commits into from
Apr 17, 2024
Merged

Conversation

rauno56
Copy link
Contributor

@rauno56 rauno56 commented Apr 15, 2024

GET /actions/types/RenameAttribute/:id

{
  "actionName": "Rename network attributes",
  "signals":
  [
    "LOGS",
    "METRICS",
    "TRACES"
  ],
  "renames":
  {
    "net.host.ip": "network.local.address",
    "net.local.address": "network.local.address",
    "net.peer.address": "network.peer.address",
    "net.peer.ip": "network.peer.address"
  }
}

Example rename action(apply with kubectl for testing if needed):

apiVersion: actions.odigos.io/v1alpha1
kind: RenameAttribute
metadata:
  name: ra-9sz8q
  namespace: odigos-system
spec:
  actionName: Rename network attributes
  renames:
    net.peer.address: network.peer.address
    net.local.address: network.local.address
    net.peer.ip: network.peer.address
    net.host.ip: network.local.address
  signals:
  - LOGS
  - METRICS
  - TRACES

@rauno56 rauno56 requested a review from a team as a code owner April 15, 2024 13:26
Copy link
Collaborator

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rauno56

What about adding this action to the odigos docs? is it something you plan for a followup PR?

@rauno56
Copy link
Contributor Author

rauno56 commented Apr 16, 2024

Writing the docs right right now actually.

@rauno56
Copy link
Contributor Author

rauno56 commented Apr 16, 2024

Added a fix for e2e tests helm charts for the time being.

@blumamir blumamir merged commit a2bfa6c into odigos-io:main Apr 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants