-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable question chaining #660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Add `recursive=False` to `Dataset` instantiations.
13 tasks
BREAKING CHANGE: Update all services in your service network to use this version or later of `octue`
160252e
to
7811eee
Compare
BREAKING CHANGE: Update all services in your service network to use this version or later of `octue`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
==========================================
- Coverage 94.62% 94.56% -0.06%
==========================================
Files 82 82
Lines 3552 3626 +74
==========================================
+ Hits 3361 3429 +68
- Misses 191 197 +6 ☔ View full report in Codecov by Sentry. |
BREAKING CHANGE: Update all services in your service network to use this version or later of `octue`.
BREAKING CHANGE: Update all services in your service network to use this version or later of `octue`. skipci
This reverts commit 55a8349.
skipci
skipci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This release makes major improvements to event handling and question auditing. Some of the main changes are:
Contents (#660)
IMPORTANT: There are 6 breaking changes.
New features
Events
parent_question_uuid
,originator_question_uuid
,originator
andretry_count
event attributesEvent handlers
EventReplayer
to handle question eventsRegisteredTemporaryDirectory
class, use it when downloading datasets, and add ability to delete them at end of analysisEnhancements
Resources
Dataset
Services
name
argument fromService
and provide an SRUID toChild
internal service instead of a nameChild.ask_multiple
order
event attributeChild.ask_multiple
Subscriptions
create_push_subscription
Questions and events
sender
argument fromget_events
and make getting the tail of events the defaultretry_count
attributeget_events
if no events for questionService configuration
delete_local_files
in service configurationoverrides
option toRunner.from_configuration
Other
PYTHONUNBUFFERED
envvar is unsetFixes
Child.ask_multiple
for failed questionsRunner.run
octue get-diagnostics
get_events
Child.ask_multiple
max_workers
when CPU count is indeterminatedelete_local_files
by defaultOperations
Dependencies
Sphinx
and other docs package rangesdb-dtypes
packagegoogle-cloud-bigquery
a mandatory dependencygoogle-cloud-secret-manager
Refactoring
Event handlers
originator
event attribute toparent
Runner
Upgrade instructions
recursive=False
toDataset
instantiationsoctue>=0.56.0
0.6.1
of the event handler or above and a correspondingly up-to-date BigQuery table.internal_service_name
argument forinternal_sruid
argument toChild.__init__
and provide a valid SRUIDService
can no longer be given names. Please give them a valid SRUID instead.Child.ask_multiple
, access the zeroth element e.g. if the third question failed:Service.received_events
,AbstractEventHandler.handled_events
, andChild.received_events
now include event attributes instead of just the event. These attributes/properties now return a list of dictionaries with the keys {"event", "attributes"}, where what was previously returned is now mapped to the "event" key.recipient
argument toEventReplayer
andGoogleCloudPubSubEventHandler
- it's now automatically acquired from each event's attributesskip_missing_events_after
argument toEventReplayer
andGoogleCloudPubSubEventHandler
awaiting_missing_event
andtime_since_missing_event
properties on the event handlers