Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the datetime field from delivery_acknowledgement and heartbeat events #641

Closed
cortadocodes opened this issue Apr 11, 2024 · 0 comments · Fixed by #660
Closed

Remove the datetime field from delivery_acknowledgement and heartbeat events #641

cortadocodes opened this issue Apr 11, 2024 · 0 comments · Fixed by #660
Assignees
Labels
framework Octue app or twined framework and communications system tech-debt Technical debt (tidy up, refactoring, restructuring, caused by laziness now)

Comments

@cortadocodes
Copy link
Member

Feature request

Current state

We're about to have datetime duplicated for delivery_acknowledgement and heartbeat events (it's about to be added to the attributes of all events, so there's no need to keep it in the event too). To reduce confusion and event size, we should remove it from these events.

Proposed Solution

  • Remove the datetime field from the delivery_acknowledgement and heartbeat events
  • Update the event handler to utilise attributes as well as events
@cortadocodes cortadocodes added tech-debt Technical debt (tidy up, refactoring, restructuring, caused by laziness now) framework Octue app or twined framework and communications system labels Apr 11, 2024
@cortadocodes cortadocodes self-assigned this Jul 2, 2024
@cortadocodes cortadocodes linked a pull request Jul 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework Octue app or twined framework and communications system tech-debt Technical debt (tidy up, refactoring, restructuring, caused by laziness now)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant