fix: bump minimal retry in case of secondary rate limiting to 60s #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
force-pushed
the
bump-minimal-retry-for-secondary-rate-limit-to-60s
branch
from
0994735
to
eccc64a
Compare
kfcampbell
previously approved these changes
May 15, 2023
…e it, to avoid a breaking change
|
Sorry I wasn't quite done. The failing tests were legit. I forgot that we have to properly deprecate the |
gr2m
added
Type: Bug
…ent settings?! No idea, not worth investigating as the code gets removed soon anyway
This was referenced May 16, 2023
Merged
kfcampbell
approved these changes
May 19, 2023
|
🎉 This PR is included in version 5.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a GitHub-internal discussion about this. We cannot give details on how secondary limit rating works as it is meant to avoid API abuse. But for now we came to an agreement that waiting 60s for retries is a good default implementation for handling.
Closes #454, closes #566.