Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: v6 #592

Merged
merged 16 commits into from
May 22, 2023
Merged

feat: v6 #592

merged 16 commits into from
May 22, 2023

Conversation

wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented May 13, 2023 •
edited
Loading

BREAKING CHANGE: Drop support for NodeJS v14, v16
BREAKING CHANGE: Drop the deprecated onAbuseHandler events

@wolfy1339 wolfy1339 added Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Tests, Refactorings, Automation, etc labels May 13, 2023
@wolfy1339 wolfy1339 force-pushed the remove-eol-node-versions branch 2 times, most recently from 83b5166 to 2bf95f7 Compare May 13, 2023 16:29
gr2m
gr2m reviewed May 13, 2023
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we also use the deprecated onAbuseLimit while at it?

@wolfy1339
Copy link
Member Author

Yeah. Sounds good

@wolfy1339 wolfy1339 changed the title ci: stop testing against NodeJS v14 ci: stop testing against NodeJS v14, v16 May 14, 2023
@wolfy1339 wolfy1339 changed the title ci: stop testing against NodeJS v14, v16 feat: v6 May 14, 2023
@kfcampbell
Copy link
Member

I asked this on another issue, but I'm curious why we're removing Node 14 before its end of life, which is September.

@wolfy1339
Copy link
Member Author

It was suggested by gr2m in octokit/webhooks.js#849 (review)

In order to avoid making another breaking release in a couple months

kfcampbell
kfcampbell previously approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you.

@gr2m
Copy link
Contributor

gr2m commented May 16, 2023

could we merge #594 first, and then remove the minimalSecondaryRateRetryAfter option that is deprecated as part of that PR? It's also quite an important fix, would be good if folks who use v5 today would get it, without the need to upgrade

@wolfy1339
Copy link
Member Author

could we merge #594 first, and then remove the minimalSecondaryRateRetryAfter option that is deprecated as part of that PR?

Sure thing 👍

@gr2m
Copy link
Contributor

gr2m commented May 21, 2023

could we merge #594 first

it's done!

gr2m
gr2m previously approved these changes May 21, 2023
View reviewed changes
@gr2m gr2m self-assigned this May 21, 2023
@gr2m gr2m removed their assignment May 21, 2023
@wolfy1339 wolfy1339 merged commit 32b598d into main May 22, 2023
@wolfy1339 wolfy1339 deleted the remove-eol-node-versions branch May 22, 2023 01:05
@github-actions
Copy link
Contributor

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

@kfcampbell kfcampbell kfcampbell left review comments

Assignees
No one assigned
Labels
released Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Tests, Refactorings, Automation, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wolfy1339 @kfcampbell @gr2m