Fix using named filters with InputTextMultiline #4410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocornut
changed the title
|
Squash incoming :) |
kfsone
force-pushed
the
bug/fix-multiline-newlines
branch
3 times, most recently
from
bb49d1c to
b9b1de7
Compare
Implements ocornut#4409: `ImGui::InputTextMultiLine` stops being multi-line when the flags also specify one of the named character filters. ```cpp char b1[256] = "1A2B\n3C4D\n", b2[256] = "1A2B\n3C4D"; ImGui::InputTextMultiline("##t1", b1, 255, ImVec2(0,0), ImGuiInputTextFlags_None); ImGui::InputTextMultiline("##t2", b2, 255, ImVec2(0,0), ImGuiInputTextFlags_CharsHexadecimal); ``` In the above example, it is not possible to add a new newline to the input box, because that input gets filtered out. This fix short-circuits the existing checks on newline and tab so that are not subsequently nixed by a named filter.
kfsone
force-pushed
the
bug/fix-multiline-newlines
branch
from
b9b1de7 to
912ecd3
Compare
ocornut
pushed a commit
that referenced
this pull request
Aug 17, 2021
|
Thank you Olivier, |
AnClark
pushed a commit
to AnClark/imgui-vst-mod
that referenced
this pull request
Aug 30, 2021
AnClark
pushed a commit
to AnClark/imgui-vst-mod
that referenced
this pull request
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change leverages the existing < 0x20 check and it's newline/tab-to-flag matching to allow those characters to explicitly bypass the named filter checks when the given flag is enabled.
You can thus have a multiline input text that only allows, e.g, uppercase hex characters, but still have multipline lines.