-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImGuiInputTextFlags conflict with InputTextMultiline #4409
Labels
Comments
kfsone
added a commit
to kfsone/imgui
that referenced
this issue
Aug 8, 2021
see https://www.github.com/kfsone/imgui-stuff for a simple demo of the problem. |
kfsone
added a commit
to kfsone/imgui
that referenced
this issue
Aug 14, 2021
kfsone
added a commit
to kfsone/imgui
that referenced
this issue
Aug 14, 2021
kfsone
added a commit
to kfsone/imgui
that referenced
this issue
Aug 14, 2021
`ImGui::InputTextMultiLine` stops being multi-line when the flags also specify one of the named character filters. ```cpp char b1[256] = "1A2B\n3C4D\n", b2[256] = "1A2B\n3C4D"; ImGui::InputTextMultiline("##t1", b1, 255, ImVec2(0,0), ImGuiInputTextFlags_None); ImGui::InputTextMultiline("##t2", b2, 255, ImVec2(0,0), ImGuiInputTextFlags_CharsHexadecimal); ``` In the above example, it is not possible to add a new newline to the input box, because that input gets filtered out. This fix short-circuits the existing checks on newline and tab so that are not subsequently nixed by a named filter.
kfsone
added a commit
to kfsone/imgui
that referenced
this issue
Aug 15, 2021
Implements ocornut#4409: `ImGui::InputTextMultiLine` stops being multi-line when the flags also specify one of the named character filters. ```cpp char b1[256] = "1A2B\n3C4D\n", b2[256] = "1A2B\n3C4D"; ImGui::InputTextMultiline("##t1", b1, 255, ImVec2(0,0), ImGuiInputTextFlags_None); ImGui::InputTextMultiline("##t2", b2, 255, ImVec2(0,0), ImGuiInputTextFlags_CharsHexadecimal); ``` In the above example, it is not possible to add a new newline to the input box, because that input gets filtered out. This fix short-circuits the existing checks on newline and tab so that are not subsequently nixed by a named filter.
ocornut
pushed a commit
that referenced
this issue
Aug 17, 2021
Thank you Olivier, |
AnClark
pushed a commit
to AnClark/imgui-vst-mod
that referenced
this issue
Aug 30, 2021
AnClark
pushed a commit
to AnClark/imgui-vst-mod
that referenced
this issue
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the first, you can enter multi-line text as expected.
In the second, you can only enter hexadecimal characters -- not including enter.
In the third, you still can't insert a newline.
Suggestion: If these flags are set, allow those characters to skip the named-filter checks.
PR to follow.
The text was updated successfully, but these errors were encountered: