Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logs integration tests #655

Merged
merged 6 commits into from
Aug 28, 2024
Merged

fix logs integration tests #655

merged 6 commits into from
Aug 28, 2024

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Aug 27, 2024

Fixes #620

Changes proposed in this PR:

  • fix tests + new helper method

@paulo-ocean paulo-ocean self-assigned this Aug 27, 2024
@paulo-ocean paulo-ocean marked this pull request as ready for review August 27, 2024 16:41
@paulo-ocean paulo-ocean changed the title try fix integration tests fix logs integration tests Aug 27, 2024
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paulo-ocean paulo-ocean merged commit eaa4495 into main Aug 28, 2024
12 checks passed
@paulo-ocean paulo-ocean deleted the issue-620-fix-tests branch August 28, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log tests randomly fail
4 participants