Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log tests randomly fail #620

Closed
jamiehewitt15 opened this issue Aug 15, 2024 · 1 comment · Fixed by #655
Closed

Log tests randomly fail #620

jamiehewitt15 opened this issue Aug 15, 2024 · 1 comment · Fixed by #655
Assignees
Labels
Priority: Mid Type: Bug Something isn't working

Comments

@jamiehewitt15
Copy link
Member

jamiehewitt15 commented Aug 15, 2024

The log tests are failing (although not every time):

  93 passing (4m)
  1 failing

  1) LogDatabase CRUD
       should save a log in the database when a log.logMessage is called:

      AssertionError: expected +0 to equal 1
      + expected - actual

      -0
      +1
      
      at Context.<anonymous> (file:///home/runner/work/ocean-node/ocean-node/dist/test/integration/logs.test.js:72:33)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

I haven't been able to replicate this locally, so far I've only seen it on the CI.

It's also not always the same test that fails. For example, sometimes this test fails:

110 passing (5m)
  1 failing

  1) LogDatabase retrieveMultipleLogs with pagination
       should retrieve logs for a specific page:

      AssertionError: expected '799' to not equal '799'
      + expected - actual


      at Context.<anonymous> (file:///home/runner/work/ocean-node/ocean-node/dist/test/integration/logs.test.js:273:44)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
@jamiehewitt15 jamiehewitt15 added the Type: Bug Something isn't working label Aug 15, 2024
@paulo-ocean paulo-ocean self-assigned this Aug 27, 2024
@paulo-ocean
Copy link
Contributor

i'm gonna check these... i know how to fix the 1st one... haven't checked the 2nd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Mid Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants