Resolve block not found issue - Sapphire #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trizin
changed the title
trentmc
requested changes
Jan 18, 2024
df_py/util/blocktime.py
Outdated
Comment on lines
154
to
173
| if abs(block_timestamp - timestamp) > 60 * 15: | ||
| # pylint: disable=line-too-long | ||
| print( | ||
| "WARNING: timestamp_to_block() is returning a block that is more than 15 minutes away from the target timestamp" | ||
| ) | ||
| print("target timestamp =", timestamp) | ||
| print("block timestamp =", block_timestamp) | ||
| print("block number =", block_i) | ||
| print("delta =", abs(block_timestamp - timestamp)) | ||
| raise Exception( | ||
| "timestamp_to_block() is returning a block that is too far away" | ||
| ) | ||
| print( | ||
| "Returning block number", | ||
| block_i, | ||
| "for timestamp", | ||
| timestamp, | ||
| "diff", | ||
| abs(block_timestamp - timestamp), | ||
| ) |
There was a problem hiding this comment.
Does a unit test capture this corner case?
There was a problem hiding this comment.
Not yet, I'll add it, thanks!
trentmc
reviewed
Jan 18, 2024
|
Code Climate has analyzed commit 247f2c4 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 90.9% (90% is the threshold). This pull request will bring the total coverage in the repository to 92.8% (0.0% change). View more on Code Climate. |
|
Ignore the failing "Dispense Predictoor ROSE Rewards" flow, there's an issue with subgraph |
trentmc
approved these changes
Jan 18, 2024
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On January 18th, the active flow failed due to block not found issue originated from Oasis RPC. This PR:
block_timestamp = 0thus returning a negative value fromtimeSinceTimestampso that f(x) != 0