Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DF webapp reports a 10x volume; is it legit or is there a df-py issue? #795

Closed
2 of 3 tasks
trentmc opened this issue Jan 18, 2024 · 1 comment
Closed
2 of 3 tasks
Assignees
Labels
Type: Bug Something isn't working

Comments

@trentmc
Copy link
Member

trentmc commented Jan 18, 2024

Background

From this slack thread:

Norbert: Looks like the current round's DCV just did a 10x, probably an issue? 👀

Screenshot 2024-01-18 at 10 37 08

(Norbert cont'd): the active rewards amount distributed is similar to the amounts distributed in the last weeks, also no change in APY so It's probably just a df-sql issue

Trent: Berkay discovered a bug in distributions of the last few rounds. He fixed it for today's distribution.

Norbert: that was related to querying the user allocations, shouldn't affect DCV. But could affect user rewards because now users that were not taken in consideration in the last rounds are now accounted and due to this other users got less rewards( one user on discords complains about this, his allocations didn't change but got half of the last weeks rewards )

Trent: Thanks for the clarification.

Norbert: This two things have lead to a strange combination as the user on Discord pointed out, 10x DCV increase but less rewards compared to previous week. Might be good to share these bugs/fixes with users in the future so they are aware why their rewards unexpectedly change.

Trent: Good point. I've added that as a TODO to the issue. Could you share the link to the discord discussion here please?

Norbert: https://discord.com/channels/612953348487905282/993954438790258879/1197327111090884740

Trent: Thanks, added link to the issue.

TODOs

  • Write a unit test to try to capture the issue, or at least clarify where the Q's are
  • If it is an issue, fix it. When done, unit test should pass
  • Get back to the discord user on the result, ie "the problem & the fix" or "it's ok, here's why __". See context & link in "background" section
@trentmc trentmc added the Type: Bug Something isn't working label Jan 18, 2024
@trentmc trentmc assigned calina-c and trizin and unassigned calina-c Jan 18, 2024
@trizin
Copy link
Contributor

trizin commented Jan 18, 2024

This was due to miscalculation of start and end blocks for Sapphire, #793 fixes it.

@trizin trizin closed this as completed Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants