[new release] rtree (0.1.1) #24288
[new release] rtree (0.1.1) #24288
Conversation
CHANGES: ## Bugs, Fixes and Optimisations - Remove extra length calculations (geocaml/ocaml-rtree#16, @lindig) - Remove some polymorphic comparisons and replace with `Float` functions (geocaml/ocaml-rtree#15, @patricoferris) - Fix stack overflows in OMT and Rectangle.merge (geocaml/ocaml-rtree#14, @patricoferris, reported by @lindig)
| tags: ["spatial" "index"] | ||
| homepage: "https://github.com/geocaml/ocaml-rtree" | ||
| bug-reports: "https://github.com/geocaml/ocaml-rtree/issues" | ||
| depends: [ |
There was a problem hiding this comment.
| depends: [ | |
| depends: [ | |
| "ocaml" {>= "4.08"} |
IIUC it is a policy to explicitly add ocaml dependency lower bounds
(we probably want to add it to packages/rtree/rtree.0.1.0/opam as well)
@mseri @kit-ty-kate please point out if I'm wrong on this.
There was a problem hiding this comment.
It does need a dependency on ocaml, but no lower bound is needed just yet. We haven't yet firmed up how exactly to enforce the <4.08 OCaml testing.
There was a problem hiding this comment.
as this PR is already merged and a dependency to ocaml is not added yet.
do you think it's a good idea to open a PR to add ocaml to both rtree.0.1.0 and rtree.0.1.1 opam files?
There was a problem hiding this comment.
Yes, thanks! Sorry for the oversight
There was a problem hiding this comment.
Yes, thanks! Sorry for the oversight
Thanks for the response! Here we go:
There was a problem hiding this comment.
Thanks all! :))
Perhaps this is something that could be added to:
- opam-repo-ci linter https://github.com/ocurrent/opam-repo-ci/blob/master/lib/lint.ml
- the ocaml-ci linter https://github.com/ocurrent/ocaml-ci/blob/master/lib/lint.ml ?
In the meantime I'll update the source code to add it, thanks again.
|
Thanks |
A pure OCaml R-Tree implementation
CHANGES:
Bugs, Fixes and Optimisations
Floatfunctions (Remove some polymorphic comparison functions geocaml/ocaml-rtree#15, @patricoferris)