Fix stackoverflows #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricoferris
added a commit
to patricoferris/opam-repository
that referenced
this pull request
Aug 17, 2023
CHANGES: ## Bugs, Fixes and Optimisations - Remove extra length calculations (geocaml/ocaml-rtree#16, @lindig) - Remove some polymorphic comparisons and replace with `Float` functions (geocaml/ocaml-rtree#15, @patricoferris) - Fix stack overflows in OMT and Rectangle.merge (geocaml/ocaml-rtree#14, @patricoferris, reported by @lindig)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: ## Bugs, Fixes and Optimisations - Remove extra length calculations (geocaml/ocaml-rtree#16, @lindig) - Remove some polymorphic comparisons and replace with `Float` functions (geocaml/ocaml-rtree#15, @patricoferris) - Fix stack overflows in OMT and Rectangle.merge (geocaml/ocaml-rtree#14, @patricoferris, reported by @lindig)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted by @lindig (thanks!) -- Both the use of
List.mapand the rectanglemerge_manyfunctions weren't tail-recursive leading to stack overflows.