Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test_symlink #771

Merged
merged 2 commits into from
Oct 21, 2024
Merged

fix: test_symlink #771

merged 2 commits into from
Oct 21, 2024

Conversation

create2000
Copy link
Contributor

worked on the test_symlink function

@create2000 create2000 mentioned this pull request Oct 18, 2024
Closed
@create2000
Copy link
Contributor Author

Hello @patricoferris -- Here is the new PR

patricoferris
patricoferris approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@patricoferris patricoferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and works for me, could you just indent the if not code to match the rest? I was going to do it but I can't push to your PR.

@create2000
Copy link
Contributor Author

Thank you @patricoferris -- I have fixed the indentation.

talex5
talex5 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@talex5 talex5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

The reason dune isn't warning about unused functions here (there are others too) is that the tests are spread across multiple files. Possibly we could do with some nearly-empty .mli files here (but not needed as part of this PR).

@patricoferris patricoferris merged commit eb8fe3e into ocaml-multicore:main Oct 21, 2024
5 checks passed
create2000 added a commit to create2000/eio that referenced this pull request Nov 20, 2024
@create2000
Check if windows has_symlink for tests (ocaml-multicore#771)
4254b41 
Symlinking is privileged operation on Windows, so we check if the running user can make symlinks before running tests that require them.
webbunivAdmin pushed a commit to webbunivAdmin/eio that referenced this pull request Nov 21, 2024
@create2000 @webbunivAdmin
Check if windows has_symlink for tests (ocaml-multicore#771)
b9bba29 
Symlinking is privileged operation on Windows, so we check if the running user can make symlinks before running tests that require them.
talex5 added a commit to talex5/opam-repository that referenced this pull request Nov 23, 2024
@talex5
[new release] eio (5 packages) (1.2)
106f265 
CHANGES:

Changes:

- Make `fork_action.h` a public header (@patricoferris ocaml-multicore/eio#769, reviewed by @talex5).
  Allows other libraries to add new actions.

- Record trace event when spawning processes (@talex5 ocaml-multicore/eio#749).
  Spawning a subprocess can take a long time in some cases, so show it clearly in the traces.

- Eio_unix.Net: make some return types more polymorphic (@talex5 ocaml-multicore/eio#744).

Bug fixes:

- Preserve backtraces in `fork_daemon` (@talex5 ocaml-multicore/eio#779).

- Eio.Path: always use "/" as separator (@talex5 ocaml-multicore/eio#743).

Linux backend:

- Allow `alloc_fixed_or_wait` to be cancelled (@talex5 ocaml-multicore/eio#753).

- Avoid triggering a (harmless) TSan warning (@talex5 ocaml-multicore/eio#754, reported by @avsm).

Windows backend:

- Unregister FDs on cancel (@talex5 ocaml-multicore/eio#756).
  Fixes `exception Unix.Unix_error(Unix.ENOTSOCK, "select", "")`.

- Work around problems in `Unix.getaddrinfo` (@talex5 ocaml-multicore/eio#780).
  Fixes e.g. `No addresses found for host name "127.0.0.1"`.

- Group `ECONNABORTED` with other connection reset errors (@talex5 ocaml-multicore/eio#783).

- Check `has_symlink` for tests (@create2000 ocaml-multicore/eio#771, reviewed by @patricoferris and @talex5).

- Improve `openat` error handling (@talex5 ocaml-multicore/eio#742, reported by @kentookura).
  Fixes `exception Unix.Unix_error(Unix.ENOENT, "openat", "")`.

Documentation:

- examples/fs: show how to read files while scanning (@talex5 ocaml-multicore/eio#745).

- Add example to `Buf_read.seq` documentation (@talex5 ocaml-multicore/eio#739, requested by @darrenldl and @rizo).

Build and test:

- Fix tests on OpenBSD (@talex5 ocaml-multicore/eio#782).

- Add advice about using AI for code generation (@patricoferris ocaml-multicore/eio#765, reviewed by @avsm and @talex5).

- Minor code cleanups (@talex5 ocaml-multicore/eio#755).

- Define `struct clone_args` for linux-lts versions that don't have it (@copy ocaml-multicore/eio#741, reviewed by @talex5).

- eio_linux: refactor fixed buffer code (@talex5 ocaml-multicore/eio#752).
@talex5 talex5 mentioned this pull request Nov 23, 2024
Merged
talex5 added a commit to talex5/opam-repository that referenced this pull request Nov 23, 2024
@talex5
[new release] eio (5 packages) (1.2)
2a50305 
CHANGES:

Changes:

- Make `fork_action.h` a public header (@patricoferris ocaml-multicore/eio#769, reviewed by @talex5).
  Allows other libraries to add new actions.

- Record trace event when spawning processes (@talex5 ocaml-multicore/eio#749).
  Spawning a subprocess can take a long time in some cases, so show it clearly in the traces.

- Eio_unix.Net: make some return types more polymorphic (@talex5 ocaml-multicore/eio#744).

Bug fixes:

- Preserve backtraces in `fork_daemon` (@talex5 ocaml-multicore/eio#779).

- Eio.Path: always use "/" as separator (@talex5 ocaml-multicore/eio#743).

Linux backend:

- Allow `alloc_fixed_or_wait` to be cancelled (@talex5 ocaml-multicore/eio#753).

- Avoid triggering a (harmless) TSan warning (@talex5 ocaml-multicore/eio#754, reported by @avsm).

Windows backend:

- Unregister FDs on cancel (@talex5 ocaml-multicore/eio#756).
  Fixes `exception Unix.Unix_error(Unix.ENOTSOCK, "select", "")`.

- Work around problems in `Unix.getaddrinfo` (@talex5 ocaml-multicore/eio#780).
  Fixes e.g. `No addresses found for host name "127.0.0.1"`.

- Group `ECONNABORTED` with other connection reset errors (@talex5 ocaml-multicore/eio#783).

- Check `has_symlink` for tests (@create2000 ocaml-multicore/eio#771, reviewed by @patricoferris and @talex5).

- Improve `openat` error handling (@talex5 ocaml-multicore/eio#742, reported by @kentookura).
  Fixes `exception Unix.Unix_error(Unix.ENOENT, "openat", "")`.

Documentation:

- examples/fs: show how to read files while scanning (@talex5 ocaml-multicore/eio#745).

- Add example to `Buf_read.seq` documentation (@talex5 ocaml-multicore/eio#739, requested by @darrenldl and @rizo).

Build and test:

- Fix tests on OpenBSD (@talex5 ocaml-multicore/eio#782).

- Add advice about using AI for code generation (@patricoferris ocaml-multicore/eio#765, reviewed by @avsm and @talex5).

- Minor code cleanups (@talex5 ocaml-multicore/eio#755).

- Define `struct clone_args` for linux-lts versions that don't have it (@copy ocaml-multicore/eio#741, reviewed by @talex5).

- eio_linux: refactor fixed buffer code (@talex5 ocaml-multicore/eio#752).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talex5 talex5 talex5 approved these changes

@patricoferris patricoferris patricoferris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@create2000 @talex5 @patricoferris